Skip to content

[Django Upgrade] [ENG-3947] Update markdown extension #9984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cslzchen merged 1 commit into from
Aug 17, 2022
Merged

[Django Upgrade] [ENG-3947] Update markdown extension #9984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions addons/wiki/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,12 @@ def build_html_output(content, node):
content,
extensions=[
wikilinks.WikiLinkExtension(
configs=[
('base_url', ''),
('end_url', ''),
('build_url', functools.partial(build_wiki_url, node))
]
base_url='',
end_url='',
build_url=functools.partial(build_wiki_url, node)
),
fenced_code.FencedCodeExtension(),
codehilite.CodeHiliteExtension(
[('css_class', 'highlight')]
)
codehilite.CodeHiliteExtension(css_class='highlight')
]
)

Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Werkzeug==1.0.0
Flask==1.0
gevent==1.2.2
Mako==1.0.7
Markdown==2.6.9
Markdown==3.3.7
WTForms==1.0.4
# Fork of celery 4.1.1 with https://github.com/celery/celery/pull/4278 backported,
# which fixes a bug that was causing stuck registrations
Expand Down Expand Up @@ -40,7 +40,7 @@ pymongo==3.7.1
PyYAML==6.0
tqdm==4.28.1
# Python markdown extensions for comment emails
git+https://github.com/CenterForOpenScience/mdx_del_ins.git
Comment thread
cslzchen marked this conversation as resolved.
git+https://github.com/Johnetordoff/mdx_del_ins.git@django-3
Comment thread
cslzchen marked this conversation as resolved.

certifi==2020.12.5
sendgrid==1.5.13
Expand Down
2 changes: 1 addition & 1 deletion website/project/views/comment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def update_comment_node(root_target_id, source_node, destination_node):


def render_email_markdown(content):
return markdown.markdown(content, ['del_ins', 'markdown.extensions.tables', 'markdown.extensions.fenced_code'])
return markdown.markdown(content, extensions=['mdx_del_ins', 'markdown.extensions.tables', 'markdown.extensions.fenced_code'])


@comment_added.connect
Expand Down