[ENG-3898][ENG-3899]ResourceDetail PATCH and DELETE#9991
Merged
jwalz merged 35 commits intoJul 28, 2022
Merged
Conversation
added 30 commits
July 14, 2022 16:57
`primary_osf_resource` property
identifier workflow changes
mfraezz
requested changes
Jul 27, 2022
Member
mfraezz
left a comment
mfraezz
left a comment
There was a problem hiding this comment.
A couple questions, but generally looks good. 
brianjgeiger
requested changes
Jul 27, 2022
Collaborator
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
A few questions, maybe one typo.
brianjgeiger
approved these changes
Jul 27, 2022
brianjgeiger
requested changes
Jul 28, 2022
Collaborator
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
Just a couple of tiny things. Otherwise looks good.
Co-authored-by: Brian J. Geiger <bgeiger@pobox.com>
Co-authored-by: Brian J. Geiger <bgeiger@pobox.com>
brianjgeiger
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implement PATCH and DELETE methods on the ResourceDetail endpoint
Changes
ResourceSerializer.update()to handle PATCHingResourceDetail.perform_destroy()to handle DELETEingResourceDetail.patch()to populate thesourcefieldQA Notes
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-3898
https://openscience.atlassian.net/browse/ENG-3899