Don't drop internal links#222
Merged
winhamwr merged 4 commits intoCenterForOpenScience:masterfrom Aug 26, 2016
Merged
Conversation
pydocx/export/html.py
Outdated
| attrs = { | ||
| 'id': paragraph.bookmark_name | ||
| } | ||
| return HtmlTag(tag, **attrs) |
Contributor
There was a problem hiding this comment.
How about:
return HtmlTag(tag, id=paragraph.bookmark_name
Contributor
|
Hello Tarashish, This looks very reasonable to me. Add some tests and then I think this is ready for merging. -Wes |
Contributor
Author
|
@winhamwr Hey! Thanks for the quick feedback. I have added tests now. |
winhamwr
added a commit
that referenced
this pull request
Aug 26, 2016
winhamwr
added a commit
that referenced
this pull request
Aug 26, 2016
regneel-TL
pushed a commit
to regneel-TL/pydocx
that referenced
this pull request
Feb 26, 2024
This reverts commit 9cd76ee.
regneel-TL
pushed a commit
to regneel-TL/pydocx
that referenced
this pull request
Feb 26, 2024
This reverts commit fdac283.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried fixing #221 and this is the rough solution I have for now. If this looks ok, I can polish it up and add tests.