Conversation
pydocx/parsers/Docx2Html.py
Outdated
There was a problem hiding this comment.
Can we use a line continuation here. This is pretty rough to read/review.
|
I'll wait to review this more until #28 is merged in. |
Conflicts: pydocx/parsers/Docx2Html.py pydocx/tests/test_docx.py pydocx/tests/test_xml.py
There was a problem hiding this comment.
I'm assuming that in #30 we're going to fix the indentation and spacing here.
There was a problem hiding this comment.
Wait, what's wrong with the indentation here? This is the fix.
On May 21, 2013 3:06 PM, "Wes Winham" notifications@github.com wrote:
In pydocx/parsers/Docx2Html.py:
@@ -21,16 +20,22 @@ def head(self):
}def style(self):
return textwrap.dedent('''<style>.insert{{color:red}}.delete{{color:red; text-decoration:line-through}}.center{{text-align:center}}.right{{text-align:right}}.left{{text-align:left}} .comment{{color:blue}}.pydocx-underline {text-decoration: underline;}body{{width:%(width)spx; margin:0px auto;}}</style>''') % {result = ('<style>''.pydocx-insert {color:green;}'I'm assuming that in #30https://github.com/OpenScienceFramework/pydocx/issues/30we're going to fix the indentation and spacing here.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/29/files#r4324013
.
|
Looks good. |
Stop overriding the handlers in the test cases
Stop overriding the handlers in the test cases
Stop overriding the handlers in the test cases
That defeats the purpose. Plus it's time to stop being lazy and fully convert the tests from docx2html syntax to pydocx.