chore: pin mm-design to v0.2.0 (eliminates Google Fonts CDN)#18
Merged
Conversation
mm-design v0.2.0 removes the @import url('fonts.googleapis.com/...') from tokens/typography.css. Font provisioning is now the consumer's responsibility — @fontsource packages already added in #17 handle this. Result: zero Google Fonts requests in the built bundle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miquelmatoses
added a commit
that referenced
this pull request
May 16, 2026
…ockfile (#19) The package-lock.json regenerated on macOS lacks the linux-x64 optional native binaries (@esbuild/linux-x64-gnu, @rollup/rollup-linux-x64-gnu, @tailwindcss/oxide-linux-x64-gnu, lightningcss-linux-x64-gnu, and ~70 other platform-specific packages) that 'npm ci' strictly requires on the Ubuntu CI runner. Result: PR #18 merged but its CI run (25955119126) and the subsequent deploy run (25955119111) both failed at the 'Install dependencies' step before reaching build, lint, or test. Production therefore still serves the previous successful deploy (commit 47462af, mm-design v0.1.0 with the Google Fonts @import). This commit switches all three 'npm ci' invocations to 'npm install': - .github/workflows/ci.yml (Build & lint job, Frontend tests job) - .github/workflows/deploy-frontend.yml (deploy job) Trade-off: 'npm install' is more permissive than 'npm ci'. It resolves missing optional platform-specific binaries by installing them rather than failing. The lockfile may mutate slightly during a CI run, but this is harmless because the runner is destroyed after each run. Once this commit is on main and the deploy succeeds, the mm-design v0.2.0 changes from PR #18 will reach production: the Google Fonts @import will be eliminated from vendor-*.css, and PageSpeed mobile Performance should rise from 70 to ~85+ as expected. Long-term alternative (not done here): regenerate the lockfile in a Linux environment via Docker or the Hetzner VPS, then restore 'npm ci'. That requires Linux access that is not currently part of the workflow. Co-authored-by: miquelmatoses <miquelmatoses@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mm-designfromgithub:miquelmatoses/mm-design(floatingmain) togithub:miquelmatoses/mm-design#v0.2.0@import url('fonts.googleapis.com/...')fromtokens/typography.css— font provisioning is now the consumer's responsibility@fontsourcepackages added in perf(mobile): self-host fonts, preconnect API, fix yellow contrast #17 already handle font provisioning locallygrep -rl "fonts.googleapis" dist/→ zero matchesRoot cause (why this was blocked)
npm had a stale lock entry pointing to an old git SHA (
f115da6f…→ v0.1.0 commit). The fix required deletingpackage-lock.jsonand doing a cleannpm installto force re-resolution to the correct commit (4d4fac10…, the actual v0.2.0 tagged commit).Test plan
cat node_modules/mm-design/package.json | grep version→"version": "0.2.0"grep -i "fonts.googleapis" node_modules/mm-design/tokens/typography.css→ zero matchesnpm run build→ clean build in 2.03sgrep -rl "fonts.googleapis" dist/→ zero matches🤖 Generated with Claude Code