Skip to content

Added rowPitch field to ImageAssetMipPosition struct. #1259

Draft
david-lively wants to merge 7 commits into
mainfrom
add-mipmap-dimensions
Draft

Added rowPitch field to ImageAssetMipPosition struct. #1259
david-lively wants to merge 7 commits into
mainfrom
add-mipmap-dimensions

Conversation

@david-lively
Copy link
Copy Markdown
Contributor

@david-lively david-lively commented Oct 8, 2025

Added ImageAssetMipPosition::rowPitch field. This is used in cesium-unity when loading textures when flipping them vertically to match Unity's U-right, V-up convention.

This should be released in conjunction with CesiumGS/cesium-unity#611 .

@david-lively david-lively changed the base branch from main to 0.52.2 October 9, 2025 15:39
Copy link
Copy Markdown
Contributor

@j9liu j9liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @david-lively for the PR! Just a handful of small comments, nothing too major.

Comment thread CesiumGltf/include/CesiumGltf/ImageAsset.h Outdated
Comment thread CesiumRasterOverlays/src/GeoJsonDocumentRasterOverlay.cpp Outdated
Comment thread CesiumVectorData/test/TestVectorRasterizer.cpp Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update CHANGES.md!

@j9liu j9liu changed the base branch from 0.52.2 to main October 13, 2025 15:25
david-lively and others added 3 commits October 13, 2025 11:00
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
Co-authored-by: Janine Liu <32226860+j9liu@users.noreply.github.com>
@j9liu j9liu marked this pull request as draft April 16, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants