Fix benchmarks for pallet asset-index and pallet saft-registry

[clearloop]

Issue summary

 𝝺 ./target/release/pint benchmark -p pallet_asset_index -e "deposit" --chain pint-local                                                                                                                                                                                        
2021-09-01 19:44:50 assembling new collators for new session 0 at #0                                                                                                                                                                                                            
2021-09-01 19:44:50 assembling new collators for new session 1 at #0                                                                                                                                                                                                            
Error: Input("\n* Pallet: AssetIndex\n* Benchmark: deposit\n* Components: []\n* Verify: false\n* Error message: An overflow would occur")                                                                                                                                       
 𝝺 ./target/release/pint benchmark -p pallet_saft_registry -e "add_saft" --chain pint-local                                                                                                                                                                                     
2021-09-01 19:47:18 assembling new collators for new session 0 at #0                                                                                                                                                                                                            
2021-09-01 19:47:18 assembling new collators for new session 1 at #0                                                                                                                                                                                                            
Error: Input("\n* Pallet: SaftRegistry\n* Benchmark: add_saft\n* Components: []\n* Verify: false\n* Error message: Bad origin") 

• Benchmarks in pallet asset-index has Overflow problem
• Benchmarks in pallet asset-index has BadOrigin problem
  • seems also has the overflow problem

---

• Check the genesis balances and assets to debug this issue

Other information and links

• Regenerate weights for all pallets #266

[mattsse]

Can you try limiting the steps to 1, then 5, 10,... maybe this has to do with how often it's called. these options:
--steps=50
--repeat=20

[clearloop]

Can you try limiting the steps to 1, then 5, 10,... maybe this has to do with how often it's called. these options:
--steps=50
--repeat=20

Not working =.=

The error message are extracted from the documents of the errors, tried to search An overflow would occur in our repo, but no results, guess it panics in some dependencies, I'm gonna test this with the UI

[clearloop]

Self::nav() broken, because no available assets yet,

For could not add_saft, the reason is like the issue in

PINT/pallets/asset-index/src/tests.rs

Line 115 in 810ea66

fn can_add_saft() {

, add another liquid asset will be able to fix it

[clearloop]

The issue in deposit is #292 (comment)

Once the nav of an asset is too little, it will be converted to 0 in

PINT/pallets/asset-index/src/lib.rs

Line 1028 in ba8db32

fn calculate_net_liquid_value(asset: T::AssetId, units: T::Balance) -> Result<T::Balance, DispatchError> {

And then the calculation will be broken, we might need to return Price but not Balance in these methods

[mattsse]

This is an issue if units * price < 1 ?
But this should be considered a dust amount, so we need to exclude these kind of scenario where nav of an asset is 0 ?

[clearloop]

Just fixed by increasing the price of the asset

This is an issue if units * price < 1 ?

Yep,

But this should be considered a dust amount, so we need to exclude these kind of scenario where nav of an asset is 0 ?

The other reason is the provided price is too little in the tests...42_u8 with decimals 8, what about adding some errors or checks for handling dust amount?

[mattsse]

Just fixed by increasing the price of the asset

This is an issue if units * price < 1 ?

Yep,

But this should be considered a dust amount, so we need to exclude these kind of scenario where nav of an asset is 0 ?

The other reason is the provided price is too little in the tests...42_u8 with decimals 8, what about adding some errors or checks for handling dust amount?

So the issue is we're using way too little amount. Since we expect values with 8-12 decimals. I think this is fine if we bump the number in the test.

[clearloop]

So the issue is we're using way too little amount. Since we expect values with 8-12 decimals. I think this is fine if we bump the number in the test.

Yep, fixed now QAQ