Conversation
Contributor
This is one not clear for me, Assets can be submitted by different accounts, but are always unique.
This is a very good point. Yes unique int ids make the most sense, I guess the What we certainly need is some kind of additional metadata struct for every asset, something like similar to chainlink feed info I don't think we have a proper storage map for this, we have the |
This was referenced Jun 10, 2021
Closed
clearloop
commented
Jun 15, 2021
mattsse
suggested changes
Jun 16, 2021
Contributor
mattsse
left a comment
There was a problem hiding this comment.
I think keeping Metadata separate will be more convenient
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
mattsse
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After thinking about it over again, I don't think refactoring
AssetIdtoenumis a better idea, the following is whatAssetIdis in my current understandingenum, theenumhave to wrap something which can make Assets different from others, and the easiest and the most practical type isnumbernumberChanges
AssetId: + AtLeast32BitUnsignedTests
Issues
Closes #102
Closes #115