Skip to content

feat(benchmarks): complete benchmarks of pallet asset-index#262

Merged
mattsse merged 13 commits intomainfrom
cl/weights
Aug 18, 2021
Merged

feat(benchmarks): complete benchmarks of pallet asset-index#262
mattsse merged 13 commits intomainfrom
cl/weights

Conversation

@clearloop
Copy link
Contributor

@clearloop clearloop commented Aug 14, 2021

Changes

  • remove_asset
  • withdraw
  • complete withdraw
  • unlock

Tests


Issues

@dutterbutter dutterbutter added the WIP Work in progress - do not review or merge label Aug 18, 2021
@clearloop
Copy link
Contributor Author

𝝺 WASMTIME_BACKTRACE_DETAILS=1 ./target/release/pint benchmark -p pallet_asset_index -e '*' --execution Wasm --wasm-execution Compiled --raw --output ./runtime/common/src/weights/pallet_asset_index.rs --chain pint-local                       
2021-08-18 15:44:45 assembling new collators for new session 0 at #0    
2021-08-18 15:44:45 assembling new collators for new session 1 at #0    
2021-08-18 15:44:46 panicked at 'Expected Ok(_). Got Err(
    <wasm:stripped>,
)', /Users/clearloop/code/PINT/pallets/asset-index/src/benchmarking.rs:72:9    
Error: Input("Error executing runtime benchmark: Other(\"Wasm execution trapped: wasm trap: unreachable\\nwasm backtrace:\\n    0: 0x22d9 - <unknown>!rust_begin_unwind\\n\")")

Could not generate weights caused by some wasm issue

@clearloop clearloop marked this pull request as ready for review August 18, 2021 07:46
@clearloop clearloop added needs review PR needs reviewing and removed WIP Work in progress - do not review or merge labels Aug 18, 2021
@clearloop clearloop requested a review from mattsse August 18, 2021 08:03
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
regarding the weights, let's just assume that will get resolved on its own.

@mattsse mattsse added approved PR approved to merge and removed needs review PR needs reviewing labels Aug 18, 2021
@mattsse mattsse merged commit 059ee8a into main Aug 18, 2021
@mattsse mattsse deleted the cl/weights branch August 18, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR approved to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants