Skip to content

feat: add root calls#335

Merged
mattsse merged 1 commit intomainfrom
cl/root-calls
Sep 8, 2021
Merged

feat: add root calls#335
mattsse merged 1 commit intomainfrom
cl/root-calls

Conversation

@clearloop
Copy link
Contributor

@clearloop clearloop commented Sep 6, 2021

Changes

  • force_add_asset
  • force_remove_asset
  • force_add_saft
  • force_remove_saft

Tests

CI

Issues

@clearloop clearloop marked this pull request as ready for review September 7, 2021 11:45
@clearloop clearloop requested a review from mattsse September 7, 2021 11:45
@clearloop clearloop added the needs review PR needs reviewing label Sep 7, 2021
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes in remove_saft were not intended, right?

@mattsse mattsse added needs changes PR needs changes and removed needs review PR needs reviewing labels Sep 7, 2021
@clearloop clearloop requested a review from mattsse September 8, 2021 06:12
@clearloop clearloop added needs review PR needs reviewing and removed needs changes PR needs changes labels Sep 8, 2021
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 88f77dd into main Sep 8, 2021
@mattsse mattsse deleted the cl/root-calls branch September 8, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review PR needs reviewing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dispatchables for root origin

2 participants