Skip to content

Avoid unexpected infinity when aggregating pub keys #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nulltea merged 3 commits into from
Mar 5, 2024
Merged

Avoid unexpected infinity when aggregating pub keys #65

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
386c56c
aggregate from pk[0] or identity
nulltea Feb 27, 2024
f6c0755
Merge branch 'main' into nulltea/pk_aggr_avoid_infinity
nulltea Mar 5, 2024
2fc84ef
fix merge
nulltea Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions lightclient-circuits/src/sync_step_circuit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ impl<S: Spec, F: Field> StepCircuit<S, F> {
fp_chip: &FpChip<'_, F>,
pubkey_affines: &[G1Affine],
pariticipation_bits: &[bool],
assigned_pubkeys: &mut Vec<G1Point<F>>,
assigned_affines: &mut Vec<G1Point<F>>,
y_signs_packed: &mut Vec<AssignedValue<F>>,
) -> (G1Point<F>, AssignedValue<F>) {
let gate = fp_chip.gate();
Expand Down Expand Up @@ -355,33 +355,37 @@ impl<S: Spec, F: Field> StepCircuit<S, F> {
fp_chip.limb_bases[1],
);

assigned_pubkeys.push(assigned_affine);
assigned_affines.push(assigned_affine);
participation_bits.push(participation_bit);
y_signs.push(y_sign);
}

let rand_point = g1_chip.load_random_point::<G1Affine>(ctx);
let mut acc = rand_point.clone();
let mut acc = {
let x = fp_chip.load_constant(ctx, G1Affine::identity().x);
let y = fp_chip.load_constant(ctx, G1Affine::identity().y);
G1Point::new(x, y) // identity
};
acc = g1_chip.select(ctx, assigned_affines[0].clone(), acc, participation_bits[0]);
for (bit, point) in participation_bits
.iter()
.copied()
.zip(assigned_pubkeys.iter_mut())
.zip(assigned_affines.iter_mut())
.skip(1)
{
let is_equal = g1_chip.is_equal(ctx, acc.clone(), point.clone());
let add = g1_chip.add_unequal(ctx, acc.clone(), point.clone(), true);
let doub = g1_chip.double(ctx, acc.clone());
let sum = g1_chip.select(ctx, doub, add, is_equal);
acc = g1_chip.select(ctx, sum, acc, bit);
}
let agg_pubkey = g1_chip.sub_unequal(ctx, acc, rand_point, false);
let participation_sum = gate.sum(ctx, participation_bits);

*y_signs_packed = y_signs
.chunks(F::CAPACITY as usize - 1)
.map(|chunk| gate.bits_to_num(ctx, chunk))
.collect_vec();

(agg_pubkey, participation_sum)
(acc, participation_sum)
}
}

Expand Down