Merged
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
commented
Jan 29, 2025
Comment on lines
+35
to
+39
| if (timeSinceLastCheck < sampleEveryMs) { | ||
| // If last call was wade 50% faster than the sampleEveryMs, let's reduce the sample interval to 10% | ||
| if (sampleEveryMs > 2 && sampleEveryMs / 2 > timeSinceLastCheck) { | ||
| sampleEveryMs -= sampleEveryMs * 0.1; | ||
| } |
Author
There was a problem hiding this comment.
This is the dynamic logic to reduce the sampling interval.
This was referenced Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implement dynamic sampling time
Description
Steps to test or reproduce