Skip to content

fix: use parseAsync to propagate async handler errors to exit code #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nazarhussain merged 2 commits into from
Mar 30, 2026
Merged

fix: use parseAsync to propagate async handler errors to exit code #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e857a58
fix: use parseAsync to propagate async handler errors to exit code
lodekeeper Mar 28, 2026
bcfa44f
fix: gracefully handle comment posting errors on fork PRs
lodekeeper Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/cli/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {compare} from "./compare.ts";
import {CLIOptions, benchmarkOptions, fileCollectionOptions, storageOptions} from "./options.ts";
import {run} from "./run.ts";

void yargs(hideBin(process.argv))
yargs(hideBin(process.argv))
.env("BENCHMARK")
.scriptName("benchmark")
.command({
Expand Down Expand Up @@ -83,4 +83,7 @@ void yargs(hideBin(process.argv))
console.error(` ✖ ${errorMessage}\n`);
process.exit(1);
})
.parse();
.parseAsync()
.catch(() => {
// Error already handled by .fail() handler
});
16 changes: 11 additions & 5 deletions src/cli/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,17 @@ export async function run(opts_: FileCollectionOptions & StorageOptions & Benchm

debug("detecting to post comment. skipPostComment: %o, isGaRun: %o", !opts.skipPostComment, isGaRun());
if (!opts.skipPostComment && isGaRun()) {
await postGaComment({
commentBody: performanceReportComment(resultsComp),
tag: GithubCommentTagEnum.PerformanceReport,
commentOnPush: resultsComp.someFailed,
});
try {
await postGaComment({
commentBody: performanceReportComment(resultsComp),
tag: GithubCommentTagEnum.PerformanceReport,
commentOnPush: resultsComp.someFailed,
});
} catch (e) {
// Don't fail the benchmark run due to comment posting errors
// (e.g. fork PRs lack pull-requests:write permission)
consoleLog(`Warning: Failed to post GitHub comment: ${(e as Error).message}`);
}
}

if (resultsComp.someFailed && !opts.noThrow) {
Expand Down
Loading