Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Conversation

@typestring
Copy link
Contributor

@typestring typestring commented Feb 10, 2023

Description

Sign transactions using a signer interface instead of a private key. This will allow to use custom singers such as a remote signer.

Related Issue Or Context

We are experimenting with your repo and the only problem we are facing right now is that one of our requirements is using a remote signer.
With this changes a custom signer could be implemented and passed down to evmclient to sign transactions without the need of a private key.

Closes: #

How Has This Been Tested? Testing details.

provided unit tests and local setup

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2023

CLA assistant check
All committers have signed the CLA.

@typestring typestring closed this Feb 10, 2023
@typestring typestring reopened this Feb 10, 2023
Copy link
Member

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution.
Looks great!

@MakMuftic MakMuftic merged commit 76d0d57 into ChainSafe:main Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants