This repository was archived by the owner on May 9, 2024. It is now read-only.
Allow resource ID modifications #159 #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luu-alex
commented
Jun 10, 2020
steviezhang
reviewed
Jun 10, 2020
steviezhang
reviewed
Jun 10, 2020
ansermino
approved these changes
Jun 11, 2020
steviezhang
reviewed
Jun 12, 2020
| await TruffleAssert.reverts(BridgeInstance.adminSetResource( | ||
| ERC20HandlerInstance.address, initialResourceIDs[0], ERC20MintableInstance1.address), | ||
| "resourceID already has a corresponding contract address"); | ||
| it('resourceID should be updated correctly with new token contract address', async () => { |
Contributor
There was a problem hiding this comment.
For this test case i think "existing resourceID should be updated correctly with new token contract address" may be more clear. This holds for all the test cases.
steviezhang
approved these changes
Jun 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes: #159