Fix swapped transport method calls in SessionService#328
Merged
wemeetagain merged 2 commits intocayman/refreshfrom Feb 9, 2026
Merged
Fix swapped transport method calls in SessionService#328wemeetagain merged 2 commits intocayman/refreshfrom
wemeetagain merged 2 commits intocayman/refreshfrom
Conversation
Co-authored-by: wemeetagain <1348242+wemeetagain@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update refresh dependencies based on review feedback
Fix swapped transport method calls in SessionService
Feb 9, 2026
wemeetagain
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addExpectedResponseandremoveExpectedResponsemethods in SessionService were delegating to opposite transport methods, breaking the rate-limiter's expected-response accounting.Changes:
addExpectedResponseto calltransport.addExpectedResponse(was callingremoveExpectedResponse)removeExpectedResponseto calltransport.removeExpectedResponse(was callingaddExpectedResponse)Impact:
Without this fix, sending requests would decrement the expected-response counter and completing requests would increment it, causing legitimate responses to be rate-limited and the counter to grow unbounded.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.