Skip to content

CidVariant refactor#3388

Merged
jdjaustin merged 6 commits into
mainfrom
jdjaustin/issue-3367-refactor-cidvariant-impl
Aug 18, 2023
Merged

CidVariant refactor#3388
jdjaustin merged 6 commits into
mainfrom
jdjaustin/issue-3367-refactor-cidvariant-impl

Conversation

@jdjaustin
Copy link
Copy Markdown
Contributor

@jdjaustin jdjaustin commented Aug 16, 2023

Summary of changes

Changes introduced in this pull request:

  • Renamed CidVariant to SmallCid and modified type structure to hide enum details from users.

Reference issue to close (if applicable)

Closes #3367

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@jdjaustin jdjaustin marked this pull request as ready for review August 17, 2023 08:04
@jdjaustin jdjaustin requested a review from a team as a code owner August 17, 2023 08:04
@jdjaustin jdjaustin requested review from ruseinov and sudo-shashank and removed request for a team August 17, 2023 08:04
Comment thread src/ipld/frozen_cids.rs Outdated
Comment thread src/utils/cid/mod.rs Outdated
Co-authored-by: Aatif Syed <38045910+aatifsyed@users.noreply.github.com>
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/utils/cid/mod.rs Outdated
Comment thread src/ipld/frozen_cids.rs Outdated
@jdjaustin jdjaustin added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 81ef8f6 Aug 18, 2023
@jdjaustin jdjaustin deleted the jdjaustin/issue-3367-refactor-cidvariant-impl branch August 18, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor CidVariant Implementation

3 participants