Skip to content

fix(cmd/cfg): Use Babe Lead value from toml config #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kishansagathiya merged 3 commits into from
Nov 15, 2021
Merged

fix(cmd/cfg): Use Babe Lead value from toml config #2032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
399bd40
fix(cmd/cfg): Use default Babe Lead value from toml config
kishansagathiya Nov 12, 2021
42220b2
Merge branch 'development' into kishan/fix/babe-lead-flag
kishansagathiya Nov 14, 2021
1219ffe
fix tests
kishansagathiya Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/gossamer/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,11 @@ func setDotCoreConfig(ctx *cli.Context, tomlCfg ctoml.CoreConfig, cfg *dot.CoreC
cfg.BabeAuthority = tomlCfg.Roles == types.AuthorityRole
cfg.GrandpaAuthority = tomlCfg.Roles == types.AuthorityRole
cfg.GrandpaInterval = time.Second * time.Duration(tomlCfg.GrandpaInterval)
cfg.BABELead = ctx.GlobalBool(BABELeadFlag.Name)

cfg.BABELead = tomlCfg.BABELead
if ctx.IsSet(BABELeadFlag.Name) {
cfg.BABELead = ctx.GlobalBool(BABELeadFlag.Name)
}
Comment thread
kishansagathiya marked this conversation as resolved.

// check --roles flag and update node configuration
if roles := ctx.GlobalString(RolesFlag.Name); roles != "" {
Expand Down
1 change: 1 addition & 0 deletions dot/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ func DevConfig() *Config {
BabeAuthority: dev.DefaultBabeAuthority,
GrandpaAuthority: dev.DefaultGrandpaAuthority,
WasmInterpreter: dev.DefaultWasmInterpreter,
BABELead: dev.DefaultBabeAuthority,
},
Network: NetworkConfig{
Port: dev.DefaultNetworkPort,
Expand Down