Skip to content

fix(ci): run golangci-lint with integration build tag #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timwu20 merged 1 commit into from
Feb 8, 2022
Merged

fix(ci): run golangci-lint with integration build tag #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,9 @@ jobs:
- uses: actions/setup-go@v2
with:
go-version: "1.17.x"
- uses: actions/checkout@v2

- name: setup golangci-lint
run: |
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh |
sh -s -- -b $(go env GOPATH)/bin v1.43.0

- run: golangci-lint run --timeout 10m
- name: Lint
run: make lint

check-description:
name: Checks PR has title and body description
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ help: Makefile
.PHONY: lint
lint:
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.43.0
golangci-lint run
golangci-lint run --build-tags integration --timeout 10m

clean:
rm -fr ./bin
Expand Down