Skip to content

chore(mocks): clean up core mocks#2777

Merged
jimjbrettj merged 7 commits intodevelopmentfrom
jimmy/cleanupMocks
Aug 23, 2022
Merged

chore(mocks): clean up core mocks#2777
jimjbrettj merged 7 commits intodevelopmentfrom
jimmy/cleanupMocks

Conversation

@jimjbrettj
Copy link
Copy Markdown
Contributor

@jimjbrettj jimjbrettj commented Aug 23, 2022

Changes

Make core mocks more organized

  • use locally defined mocks
  • remove ./mocks
  • put generate commands in a mock_generate_test file

Tests

go test ./dot/core 
got test ./dot/rpc/modules

Issues

Progress towards #2337

Primary Reviewer

@qdm12

Copy link
Copy Markdown
Contributor

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread dot/core/interface.go Outdated
Comment thread dot/core/interface.go Outdated
Comment thread dot/core/interface.go Outdated
Comment thread dot/rpc/modules/author_integration_test.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 23, 2022

Codecov Report

Merging #2777 (d477a57) into development (f635c59) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #2777      +/-   ##
===============================================
- Coverage        62.88%   62.86%   -0.03%     
===============================================
  Files              213      213              
  Lines            27021    27021              
===============================================
- Hits             16992    16986       -6     
- Misses            8476     8483       +7     
+ Partials          1553     1552       -1     

@jimjbrettj jimjbrettj merged commit 6552e65 into development Aug 23, 2022
@jimjbrettj jimjbrettj deleted the jimmy/cleanupMocks branch August 23, 2022 23:13
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants