fix(lib/babe): integration tests bad merge#2814
Closed
qdm12 wants to merge 5 commits intodevelopmentfrom
Closed
Conversation
- Split out (CGO related) helper functions from `imports.go` to `lib/runtime/wasmer/helpers.go` - Move pointer size helper functions to `lib/runtime/wasmer/helpers.go` - Change `toWasmMemorySized` to NOT take a size argument (unneeded) - Clarify all comments for helper functions - Update all error wrappings - Review variable names - Use `ptr` instead of `out` for 32 bit pointers - Use `pointerSize` instead of `span` for 64 bit pointers size - Name return values - Other minor renamings such as `res` to `result`, `enc` to `encodedResult` - Optimizations: - `storageAppend`: use slice capacity allocation, `copy` and remove unneeded `append`s - `toKillStorageResultEnum`: use `copy` instead of `append` - `toWasmMemoryOptional`: remove unneeded variable copy
qdm12
requested review from
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot and
timwu20
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2814 +/- ##
===============================================
+ Coverage 62.97% 63.23% +0.25%
===============================================
Files 213 213
Lines 27012 27012
===============================================
+ Hits 17012 17081 +69
+ Misses 8455 8384 -71
- Partials 1545 1547 +2 |
qdm12
changed the title
Contributor
Author
|
@kishansagathiya running go test -run ^TestService_HandleSlotWithSameSlot$ github.com/ChainSafe/gossamer/lib/babe -v -tags integrationCauses |
timwu20
force-pushed
the
development
branch
from
7fa9196 to
de2d65d
Compare
Contributor
Author
|
Converting this back to draft since commit from #2726 got dropped. Let me know Kishan if/when I can close this & delete the branch. |
Contributor
Author
|
No longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Just the occasional error due to merging without being forced to rebase/update your branch. Changes are:
Timestamp must be updated only once in the blockTests
Issues
Primary Reviewer
@kishansagathiya