chore(lib/trie): review usage of node Dirty field#2921
Merged
qdm12 merged 2 commits intodevelopmentfrom Nov 9, 2022
Merged
Conversation
qdm12
force-pushed
the
qdm12/trie/dirty-review
branch
from
e4826a9 to
9b4006e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2921 +/- ##
===============================================
- Coverage 63.32% 63.13% -0.19%
===============================================
Files 219 219
Lines 27591 27590 -1
===============================================
- Hits 17471 17420 -51
- Misses 8504 8556 +52
+ Partials 1616 1614 -2 |
qdm12
requested review from
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot and
timwu20
as code owners
qdm12
force-pushed
the
qdm12/trie/dirty-review
branch
from
9b4006e to
2f07148
Compare
EclesioMeloJunior
approved these changes
Nov 8, 2022
edwardmack
approved these changes
Nov 8, 2022
qdm12
force-pushed
the
qdm12/trie/dirty-review
branch
from
2f07148 to
5ff92a2
Compare
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SetDirtycallTests
go test -tags integration github.com/ChainSafe/gossamer/lib/trie github.com/ChainSafe/gossamer/internal/trie/...Issues
Trying to fix up strange root hash mismatch panic found in #2919
Primary Reviewer
@timwu20