chore(lib/trie): remove Store method#2922
Merged
qdm12 merged 1 commit intodevelopmentfrom Nov 15, 2022
Merged
Conversation
qdm12
force-pushed
the
qdm12/trie/remove-store
branch
from
77b9e81 to
8cabfe1
Compare
qdm12
force-pushed
the
qdm12/trie/dirty-review
branch
from
9b4006e to
2f07148
Compare
qdm12
force-pushed
the
qdm12/trie/remove-store
branch
from
8cabfe1 to
1b53b7e
Compare
qdm12
requested review from
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot and
timwu20
as code owners
qdm12
force-pushed
the
qdm12/trie/dirty-review
branch
from
2f07148 to
5ff92a2
Compare
qdm12
force-pushed
the
qdm12/trie/remove-store
branch
from
1b53b7e to
728d1cf
Compare
EclesioMeloJunior
approved these changes
Nov 14, 2022
timwu20
approved these changes
Nov 14, 2022
- `WriteDirty` is just the clever version of `Store` - This ensures all the nodes are set as dirty correctly
qdm12
force-pushed
the
qdm12/trie/remove-store
branch
from
728d1cf to
cd3ed3b
Compare
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
WriteDirtyis just the clever version ofStore, where we write only nodes that got changed in-memory from the version we have in the database.Tests
go test -tags integration github.com/ChainSafe/gossamer/...Issues
Trying to fix up strange root hash mismatch panic found in #2919
Primary Reviewer
@timwu20