Skip to content

chore(lib/blocktree): Add comment to blocktree.RangeInMemory#3064

Merged
EclesioMeloJunior merged 11 commits intodevelopmentfrom
eclesio/remove-duplicated-range-function
Jan 25, 2023
Merged

chore(lib/blocktree): Add comment to blocktree.RangeInMemory#3064
EclesioMeloJunior merged 11 commits intodevelopmentfrom
eclesio/remove-duplicated-range-function

Conversation

@EclesioMeloJunior
Copy link
Copy Markdown
Member

@EclesioMeloJunior EclesioMeloJunior commented Jan 24, 2023

Changes

  • I notice that those functions are not duplicated but have a small difference and I put a comment explaining it to avoid more confusion in the future

Tests

N/A

Issues

N/A

Primary Reviewer

@kishansagathiya

@EclesioMeloJunior EclesioMeloJunior force-pushed the eclesio/remove-duplicated-range-function branch from 9f13689 to 3b4e179 Compare January 24, 2023 15:56
@EclesioMeloJunior EclesioMeloJunior self-assigned this Jan 24, 2023
@EclesioMeloJunior EclesioMeloJunior changed the title chore(lib/blocktree): remove duplicated range function chore(lib/blocktree): Add comment to blocktree.RangeInMemory Jan 24, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2023

Codecov Report

Merging #3064 (54aee8a) into development (92d40a4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #3064      +/-   ##
===============================================
- Coverage        51.53%   51.52%   -0.01%     
===============================================
  Files              219      219              
  Lines            27997    27997              
===============================================
- Hits             14427    14426       -1     
- Misses           12284    12285       +1     
  Partials          1286     1286              

Comment thread lib/blocktree/blocktree.go Outdated
Comment thread lib/blocktree/blocktree.go
@EclesioMeloJunior EclesioMeloJunior merged commit 2b5bc2b into development Jan 25, 2023
@EclesioMeloJunior EclesioMeloJunior deleted the eclesio/remove-duplicated-range-function branch January 25, 2023 21:54
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants