dot/rpc: implement RPC methods chain_getHeader and chain_getBlock#745
Merged
edwardmack merged 22 commits intodevelopmentfrom Apr 6, 2020
Merged
dot/rpc: implement RPC methods chain_getHeader and chain_getBlock#745edwardmack merged 22 commits intodevelopmentfrom
edwardmack merged 22 commits intodevelopmentfrom
Conversation
noot
reviewed
Apr 3, 2020
noot
reviewed
Apr 3, 2020
noot
reviewed
Apr 3, 2020
noot
approved these changes
Apr 3, 2020
Contributor
Author
|
I think this is ready now... |
ryanchristo
approved these changes
Apr 5, 2020
Contributor
ryanchristo
left a comment
ryanchristo
left a comment
There was a problem hiding this comment.
Nice work! Looks good to me. You can base the pull request off your other branch until it is merged if you want to separate the code in the pull request but not necessary, just something I like to do.
…om/ChainSafe/gossamer into ed/309_implement-rpc-chain-methods
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* refactor to use gorilla/rpc lib * introduce gorilla rpc package * address lint issues * implement GetHeader chain rpc func * added getBlock rpc call * add test for chain getBlock and getHeader * added TODO issue #744 to comments * fix spelling, remove extra logging, add chain to default * go fmt-ed * refactor to use gorilla/rpc lib * address lint issues * implement GetHeader chain rpc func * added getBlock rpc call * add test for chain getBlock and getHeader * added TODO issue #744 to comments * fix spelling, remove extra logging, add chain to default * go fmt-ed * fix merge issues
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests:
Unit tests:
Interactive testing, start node:
Interact with node via RPC, call chain_getHeader for latest header
Interact with node via RPC, call chain_getHeader for hash
Similar for calls to chain_getBlock
Issues:
This code introduces bug described in issue #744