dot/rpc, dot/types: fix RPC json header digest logs response#819
Merged
edwardmack merged 3 commits intodevelopmentfrom May 1, 2020
Merged
dot/rpc, dot/types: fix RPC json header digest logs response#819edwardmack merged 3 commits intodevelopmentfrom
edwardmack merged 3 commits intodevelopmentfrom
Conversation
noot
reviewed
Apr 30, 2020
| Number *big.Int `json:"number"` | ||
| StateRoot string `json:"stateRoot"` | ||
| ExtrinsicsRoot string `json:"extrinsicsRoot"` | ||
| Digest ChainBlockHeaderDigest `json:"digest"` |
Contributor
There was a problem hiding this comment.
is this in the spec? I couldn't find it anywhere
Contributor
Author
There was a problem hiding this comment.
I'm using this as spec for JSON result: https://github.com/w3f/PSPs/blob/psp-rpc-api/psp-002.md#chain_getHeader
But I see now that I should be treating number as a hex string, so I'll update that.
noot
approved these changes
Apr 30, 2020
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* fix formating of header digest logs * update digest type values to conform to spec * header number as hex string in json responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests:
Checklist:
Issues: