Skip to content

Conversation

@creeppak
Copy link
Contributor

@creeppak creeppak commented Dec 16, 2024

  • Moved "SwitchChainAddIfMissing" logic to be used in Reown only.
  • Switching chains the old simple way for all the Wallet Providers by default.

A new bug related to Reown was discovered. You can't switch chains in Reown as exception is getting thrown. It also happens in dev.

The error:

MissingMethodException: Constructor on type 'ChainSafe.Gaming.Reown.Methods.WalletAddEthereumChain' not found.

Reverted previous SwitchChain implementation to be used by default for all the WalletProviders
# Conflicts:
#	src/ChainSafe.Gaming/Web3/Evm/Wallet/IWalletProvider.cs
#	src/ChainSafe.Gaming/Web3/Evm/Wallet/WalletProvider.cs
#	src/ChainSafe.Gaming/Web3/Evm/Wallet/WalletSigner.cs
@creeppak creeppak marked this pull request as draft December 16, 2024 15:48
@creeppak creeppak marked this pull request as ready for review December 17, 2024 15:09
Copy link
Collaborator

@rob1997 rob1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! however this could conflict with #1270

@kantagara kantagara closed this Jan 18, 2025
@kantagara
Copy link
Contributor

Closed sine metamask will be removed in 3.1 in favour of appkit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants