Conversation
Owner
Author
|
The actual error location is swallowed by the parent parser. |
Owner
Author
|
Curiously, it works when passing the |
Owner
Author
|
The diagnostic is correctly propagated from the submodule, that fix the issue. There is still a bug on the files propagation, only the first file module is taken into account. |
Champii
added a commit
that referenced
this pull request
Jun 26, 2022
* Bump version * Update README to show the right version of llvm * Add the self returning method with `@->` * Add tests for self returning function * Add an embryo of documentation with mdbook * Documentation * Fix doc about struct * Doc * Add \0 as escaped char and generalize escaped char parsing (#125) * Add \0 as escaped char and generalize escaped char parsing * Inline parser variable in parse_char method * Readme * Readme * Escaped chars (#132) * Add \0 as escaped char and generalize escaped char parsing * Inline parser variable in parse_char method * Better unescaped handling * Fix escaped backslack and add tests * Restored string unescape * Fixed the `\0` escaped char * Doc * Introducing default trait methods (#128) * Introducing default trait methods * Allow for empty impl * Readme * Add tests * Allow for default method overriding * Add tests for default method overriding * Doc * Fix dot notation newline (#140) * Fix dot notation by restricting newline in dot notation when parsing an argument * Readme * Struct fields are no more reordered. (#138) * Struct fields are no more reordered. * Removed comment * Removed some old readme entry * Submodule parser errors (#137) * Subparser now fails when error * Transformed the module declaration error to failure * Fixed the diagnostic in submodule not showing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.