Fix claude get headers by lloydzhou · Pull Request #4903 · ChatGPTNextWeb/NextChat

lloydzhou · 2024-07-01T10:27:18Z

anthropic client using common getHeaders
do not send anthropicApiKey in browser!!!
always using Authorization header send access code

Summary by CodeRabbit

New Features
- Enhanced header configuration to support Azure, Google, and Anthropic providers.
Bug Fixes
- Improved API key handling for different cloud providers.
Refactor
- Streamlined header assignment logic for better maintainability.

…thorization` header send access code

vercel · 2024-07-01T10:27:22Z

@lloydzhou is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-07-01T10:27:26Z

Walkthrough

The recent update to the application introduces enhanced support for multiple providers (Azure, Google, and the new Anthropic provider) within the getHeaders function. This entails modifying how API keys and authorization headers are handled and integrating these changes into the ClaudeApi class in anthropic.ts for a streamlined and consistent authorization process across different platforms.

Changes

File	Change Summary
`app/client/api.ts`	Updated `getHeaders` function to handle `Azure`, `Google`, and newly added `Anthropic` providers.
`app/client/platforms/anthropic.ts`	Incorporated `getHeaders` into `ClaudeApi` class and removed the old `getAuthKey` function.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Api as API
    participant AccessStore
    participant ClaudeApi

    Client->>Api: Call getHeaders()
    Api->>AccessStore: Retrieve API keys based on provider
    Api-->>Client: Return headers
    
    Client->>ClaudeApi: Initialize with headers
    ClaudeApi->>Api: Import getHeaders
    ClaudeApi-->>Client: ClaudeApi instance ready

Poem

In code's domain, where APIs thrive,
New headers bloom, Anthropic alive.
With keys so neat, in seamless flow,
To Claude they go, in lines they show.
🎩🐰 With change in air, the code does dance,
For Azure and Google, and now Anthropic's chance. 🌐✨

Tip

Early access features: enabled

We are currently testing the following features in early access:

OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
Please join our Discord Community to provide feedback and report issues.
OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-07-01T10:31:33Z

Your build has completed!

Preview deployment

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c359b30 and 37e2517.

Files selected for processing (2)

app/client/api.ts (2 hunks)
app/client/platforms/anthropic.ts (3 hunks)

Files not summarized due to errors (1)

app/client/platforms/anthropic.ts: Error: Server error. Please try again later.

Files not reviewed due to errors (2)

app/client/api.ts (Error: Server error. Please try again later.)
app/client/platforms/anthropic.ts (Error: Server error. Please try again later.)

coderabbitai

Actionable comments posted: 3

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c359b30 and 37e2517.

Files selected for processing (2)

app/client/api.ts (2 hunks)
app/client/platforms/anthropic.ts (3 hunks)

Files not reviewed due to errors (1)

app/client/platforms/anthropic.ts (no review received)

Additional comments not posted (2)

app/client/api.ts (2)
165-165: Add a comment explaining the new isAnthropic flag.

Consider adding a comment explaining what the isAnthropic flag is used for to improve code readability.
const isAnthropic = accessStore.provider === ServiceProvider.Anthropic; // Check if the provider is Anthropic
187-188: Ensure the Authorization header is correctly set for access codes.

The Authorization header should always be used to send the access code, even for the Anthropic provider.
Verification successful

Ensure the Authorization header is correctly set for access codes.

The Authorization header is correctly set for access codes in the app/client/api.ts file. The code snippet shows that the Authorization header is set using the makeBearer function, which includes the accessStore.accessCode.
app/client/api.ts:
headers['Authorization'] = makeBearer(
  ACCESS_CODE_PREFIX + accessStore.accessCode,
);
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify that the `Authorization` header is correctly set for access codes.

# Test: Search for the usage of accessStore.accessCode. Expect: Occurrences in the `getHeaders` function.
rg --type python $'accessStore.accessCode'
Length of output: 72

Script:
#!/bin/bash
# Description: Verify that the `Authorization` header is correctly set for access codes in TypeScript files.

# Test: Search for the usage of accessStore.accessCode in TypeScript files.
rg --type ts 'accessStore.accessCode'
Length of output: 306

Script:
#!/bin/bash
# Description: Extract context around the usage of accessStore.accessCode in app/client/api.ts to verify if it is correctly set in the Authorization header.

# Test: Extract lines around accessStore.accessCode in app/client/api.ts to check header setting.
rg --context 10 'accessStore.accessCode' app/client/api.ts
Length of output: 763

lloydzhou added 2 commits July 1, 2024 09:41

fix: anthropic client using common getHeaders

d65ddea

fix: 1. anthropic client using common getHeaders; 2. always using `Au…

37e2517

…thorization` header send access code

lloydzhou requested a review from Dogtiti July 1, 2024 10:27

coderabbitai bot reviewed Jul 1, 2024

View reviewed changes

Comment thread app/client/api.ts

Comment thread app/client/api.ts

Comment thread app/client/api.ts

Dogtiti approved these changes Jul 2, 2024

View reviewed changes

lloydzhou merged commit 501f8b0 into ChatGPTNextWeb:main Jul 3, 2024

lloydzhou deleted the fix-claude-get-headers branch August 1, 2024 05:14

coderabbitai bot mentioned this pull request Nov 9, 2024

feat: Implement Vertex AI support for Anthropic and Google models #5794

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix claude get headers#4903

Fix claude get headers#4903
lloydzhou merged 2 commits intoChatGPTNextWeb:mainfrom
ConnectAI-E:fix-claude-get-headers

lloydzhou commented Jul 1, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 1, 2024

Uh oh!

coderabbitai bot commented Jul 1, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 1, 2024

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lloydzhou commented Jul 1, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 1, 2024

Uh oh!

coderabbitai bot commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 1, 2024

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lloydzhou commented Jul 1, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 1, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)