Load Tweets using embed endpoint if no API key is present#510
Closed
Nerixyz wants to merge 2 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 46.90% 48.19% +1.29%
==========================================
Files 99 100 +1
Lines 3710 3872 +162
==========================================
+ Hits 1740 1866 +126
- Misses 1920 1954 +34
- Partials 50 52 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Just some info: Went on for a bit trying to find info about the endpoint, vercel/react-tweet#76 Seems like it's an internal API used by Twitter's external iframe/HTML embeds. |
1 task
Member
|
I prefer the solution from #522 right now - the embed solution doesn't seem to work which tells me it's going to be a bit flaky. If there's a library we can use that keeps this up-to-date I'm open to using this approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
If no Twitter API key is configured, the twitter resolver uses the embed endpoint (used by vercel/react-tweet as well). The only downside is that retweets aren't displayed.