Skip to content

Feature nightly#47

Closed
wistcc wants to merge 5 commits intoChessCom:masterfrom
wistcc:feature-nightly
Closed

Feature nightly#47
wistcc wants to merge 5 commits intoChessCom:masterfrom
wistcc:feature-nightly

Conversation

@wistcc
Copy link
Contributor

@wistcc wistcc commented Nov 29, 2016

This PR is related to issue #46

Copy link
Member

@martynchamberlin martynchamberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know when in FireFox's pipeline they'll merge this nightly feature, chrome.storage.async? Until then, I don't think we'll notice much of a performance impact on localStorage, since the app is so lightweight.

I'm envisioning going with this PR and then creating a separate PR that has this commit in it, so we can just revert that once Firefox gets the feature into its main release.

@wistcc
Copy link
Contributor Author

wistcc commented Dec 1, 2016

After a quick Google search, I didn't get a release date, but it seems that it takes a while because Nightly is the first version of 3 before the release version (which is Firefox).

So, we could just create an issue with this, specifying that we just need to change back chrome.storage.local to chrome.storage.sync.

What do you think? @martynchamberlin

@martynchamberlin
Copy link
Member

Yep, I think that sounds good!

@martynchamberlin
Copy link
Member

Closing this PR, in favor of #48. Created #52 so it'll be on our radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants