Fix navigation property extraction for TPC inheritance in batch paging#8906
Merged
michaelstaib merged 3 commits intoNov 16, 2025
Merged
Conversation
michaelstaib
approved these changes
Nov 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8906 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes navigation property extraction for TPC (Table Per Concrete) inheritance when using batch paging with selectors, while maintaining backward compatibility for scalar property grouping.
Problem
When using TPC inheritance mapping with
QueryContextselectors andToBatchPageAsync, queries would fail with an EF Core translation error:Root Cause
The
EnsureGroupPropsAreSelectedmethod was extracting the entire member expression chain (e.g.,e.Parent.Id) instead of just the navigation property (e.g.,e.Parent). When TPC inheritance is used with selectors, EF Core needs navigation properties to be explicitly included in the projection, but the incorrect extraction meant:.Parent.Idon the projected instanceExample scenario that failed:
Solution
Adjusted the navigation property extraction logic in GetMemberExpressions to:
What's extracted: