-
Notifications
You must be signed in to change notification settings - Fork 1
ci(fidelity): ratchet-down baseline + wire into lint.yml #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
95b9593
ci(fidelity): ratchet-down baseline + wire into lint.yml (closes #53)
claude 0c7006f
chore(pypi): add keywords + broaden classifiers for discoverability
claude d1fbeac
refactor(teams): drop duplicate _escape_table_cell, use shared (#70)
claude 016586f
ci(fidelity): fail script when mapped TS files are missing
patrick-chinchill 4f7d0cf
ci(fidelity): drop continue-on-error on clone, run --strict with empt…
patrick-chinchill 404bf3e
docs: reflect strict fidelity mode + add CHANGELOG entry for 0.4.26.2
patrick-chinchill 9400d31
fix(fidelity): address coderabbit review on PR #72
patrick-chinchill 7b27e2d
fix(fidelity): preserve baseline _comment + qualify scope-of-coverage…
patrick-chinchill 638a759
docs(fidelity): finish scope-qualification sweep on PR #72
patrick-chinchill 9b3648c
fix(fidelity): use UPSTREAM_PARITY for write_baseline + scope-qualify…
patrick-chinchill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "_comment": "Ratchet-down baseline for scripts/verify_test_fidelity.py. This repo ships at strict fidelity for mapped core files (0 missing) against chat@4.26.0, so the baseline is empty. Scope: the MAPPING dict in scripts/verify_test_fidelity.py is the authoritative list of TS files checked; it currently covers 8 of the 17 packages/chat/src/*.test.ts files. Default CI mode runs --strict via .github/workflows/lint.yml; this file is retained for local workflows that want to opt back into baseline mode (e.g. during an upstream sync where several ports land in flight). To baseline genuinely-divergent tests, run scripts/verify_test_fidelity.py --update-baseline after documenting the divergence in docs/UPSTREAM_SYNC.md.", | ||
| "ts_parity": "chat@4.26.0", | ||
| "total_ts_tests": 588, | ||
| "total_missing": 0, | ||
| "missing": {} | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the clone step to the aggregate failure loop; otherwise a transient
git clonefailure (network outage, rate limit, tag fetch issue) does not fail this job. In that caseTS_ROOTis missing,verify_test_fidelity.pyskips all TS files and exits 0, so the new fidelity protection is silently bypassed while the workflow still reports success.Useful? React with 👍 / 👎.