Skip to content

longer scroll text an non-blocking scrolling#2

Open
ChrisVeigl wants to merge 3 commits intoChocho2017:masterfrom
ChrisVeigl:master
Open

longer scroll text an non-blocking scrolling#2
ChrisVeigl wants to merge 3 commits intoChocho2017:masterfrom
ChrisVeigl:master

Conversation

@ChrisVeigl
Copy link
Copy Markdown

changed data type of several variables to avoid overflow when longer scroll text is used.
added non-blocking scrolling method for doing stuff in parallel while scrolling text.

@ClemensGruber
Copy link
Copy Markdown

ClemensGruber commented Oct 15, 2022

I got a compiling error for

C:\Users\mail\Documents\Arduino\libraries\DFRobot_HT1632C\DFRobot_HT1632C.cpp:178:9: error: '*<unknown>.DFRobot_HT1632C::rd_t' is used uninitialized in this function [-Werror=uninitialized]
  rd_t = rd_t;
         ^~~~

The function is

DFRobot_HT1632C::DFRobot_HT1632C(uint8_t data, uint8_t wr, uint8_t RD, uint8_t cs){
	data_t = data;
	cs_t = cs;
	wr_t = wr;
	rd_t = rd_t;
	
	for(uint8_t i=0; i < 24; i++){
		matrix[i] = 0;
	}
	matrix[0] = 0x40;
}

So I changed rd_t = rd_t; to rd_t = RD; now it compiles without error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants