overland flow tut: code style, legends in figures, some text clarified

[nathanlyons]

Upper sections

I removed the first paragraph because I thought it would be confusing to have this broader topic under the notebook header. Vital parts of what was in the first paragraph could instead be included in the Data Science and Cyberinfrastructure section I proposed.

How about using the Objectives and About this notebook sections in each of the 3 notebooks? The notebooks are all almost set up this way. I suppose I am suggesting to make them a little more consistent...only in these sections.

Summary of changes

markdown cells in general

• changed headings that were bolded to true markdown headings using #
• corrected the few spelling errors
• minor wordsmithing for content clarity

---

code cells in general

• coding style modified to more closely follow PEP 8 (mostly spacing)
• added legends to imshow figs of the sampled points (e.g. midstream node)

---

In section 2.3 and 9.0, hs_utils is mentioned in a markdown cell, but is not clear in a code cell. I believe this refers to the lines in 2.3:

from utilities import hydroshare

hs = hydroshare.hydroshare()

For this reason, I changed hs_utils to hydroshare. Please check if this is appropriate.

---

In 2.3, 'This is the list of folders in your directory for this HydroShare resource' is followed by os.getcwd(). This is only the current directory. You could do next(os.walk('.'))[1]. Alternatively, you could remove these print statements if it doesn't add much insight.

---

Added a warning about processing time for the overland flow model cell.

---

Suppressed figure handle output, e.g. <Figure...> as well as the additional imshow output immediately after the animation by closing the imshow_grid figure.

---

Added note about needing to rerun model with different OverlandFlow option of the routing_method in response to:

KRB note, I got an error IOError: [Errno 2] No such file or directory: 'Spring Creek_HigherIntensity_OverlandFlow_2.66666666667hr_map.png

---

Removed text that indicated saving images and the animation are related. The animation does not rely on the savefig command or image_save variable. The animation module grabs the figure at time steps created by imshow_grid.

Manual testing

I did this in a Safari browser in a python 3 HydroShare kernel.

• My modified code blocks ran and printed the same output (of the output that was in the current notebook) with exception of the modified figures I explained elsewhere.
• All the links open the intended webpages.
• The animation works.

Remaining to do

• update mentions of sections
• 'KRB note: How do I download this file?' in section 6.3. I think the intent of this cell is only to list the files.