Skip to content

ENH: Add support for Singularity #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristopherMayes merged 2 commits into from
Oct 7, 2020
Merged

ENH: Add support for Singularity #1

ChristopherMayes merged 2 commits into from
Oct 7, 2020

Conversation

@hhslepicka
Copy link
Contributor

@hhslepicka hhslepicka commented Oct 7, 2020

Before instantiating the class for Superfish users will need to set the following:

Superfish._singularity_image = '<location of>/poisson-superfish_latest.sif'
  • Tested with SLAC SDF Singularity.
  • Some PEP8 issues also solved.

ChristopherMayes
ChristopherMayes reviewed Oct 7, 2020
View reviewed changes
Copy link
Owner

@ChristopherMayes ChristopherMayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ChristopherMayes ChristopherMayes merged commit cc4636f into ChristopherMayes:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristopherMayes ChristopherMayes ChristopherMayes left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hhslepicka @ChristopherMayes