Update for using with WSL plus some other small updates #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s other updates: * add note to README about code availability * update openpmd_beamphysics requirement * interpolate.py: run_cmd include optional t35 filename (needed for WSL) * superfish.py: if self.use_container is False, run windows cmd (don't check platform again) * writers.py: update deprecated np.complex * some comments added to examples about running on WSL or using custom container
ChristopherMayes
approved these changes
Apr 19, 2024
Owner
ChristopherMayes
left a comment
ChristopherMayes
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update as needed for running Windows executables from Linux side with WSL, plus other updates:
Tested all examples using WSL with Windows executables as well as with WSL/Ubuntu using custom Docker container made according to instructions on https://github.com/hhslepicka/docker-poisson-superfish-nobin/