Feature/one shot installer

first_time_install.sh

@@ -239,11 +239,20 @@ echo ""
 if [ "$ASSUME_YES" = "1" ]; then
     echo "Non-interactive mode: proceeding with installation."
 else
-    read -p "Do you want to proceed with the installation? (y/N): " -n 1 -r
-    echo
-    if [[ ! $REPLY =~ ^[Yy]$ ]]; then
-        echo "Installation cancelled."
-        exit 0
+    # Check if stdin is available (not running via pipe/curl)
+    if [ -t 0 ]; then
+        read -p "Do you want to proceed with the installation? (y/N): " -n 1 -r
+        echo
+        if [[ ! $REPLY =~ ^[Yy]$ ]]; then
+            echo "Installation cancelled."
+            exit 0
+        fi
+    else
+        # Non-interactive mode but ASSUME_YES not set - exit with error
+        echo "✗ Non-interactive mode detected but ASSUME_YES not set." >&2
+        echo "  Please run with -y flag or set LEDMATRIX_ASSUME_YES=1" >&2
+        echo "  Example: sudo ./first_time_install.sh -y" >&2
+        exit 1
     fi
 fi
 
@@ -973,28 +982,38 @@ if [ -f "$PROJECT_ROOT_DIR/scripts/install/install_wifi_monitor.sh" ]; then
 
     if [ ! -f "/etc/systemd/system/ledmatrix-wifi-monitor.service" ] || [ "$NEEDS_UPDATE" = true ]; then
         echo "Installing/updating WiFi monitor service..."
-        bash "$PROJECT_ROOT_DIR/scripts/install/install_wifi_monitor.sh"
+        # Run install script but don't fail installation if it errors (WiFi monitor is optional)
+        if bash "$PROJECT_ROOT_DIR/scripts/install/install_wifi_monitor.sh"; then
+            echo "✓ WiFi monitor service installation completed"
+        else
+            INSTALL_EXIT_CODE=$?
+            echo "⚠ WiFi monitor service installation returned exit code $INSTALL_EXIT_CODE"
+            echo "  Continuing installation - WiFi monitor is optional and can be installed later"
+        fi
+    fi
 
     # Harden service file permissions (if service was created)
     if [ -f "/etc/systemd/system/ledmatrix-wifi-monitor.service" ]; then
         chown root:root "/etc/systemd/system/ledmatrix-wifi-monitor.service" || true
         chmod 644 "/etc/systemd/system/ledmatrix-wifi-monitor.service" || true
         systemctl daemon-reload || true
-    fi
-
-    # Check if service was installed successfully
-    if systemctl list-unit-files | grep -q "ledmatrix-wifi-monitor.service"; then
-        echo "✓ WiFi monitor service installed"
 
-        # Check if service is running
-        if systemctl is-active --quiet ledmatrix-wifi-monitor.service 2>/dev/null; then
-            echo "✓ WiFi monitor service is running"
+        # Check if service was installed successfully
+        if systemctl list-unit-files | grep -q "ledmatrix-wifi-monitor.service"; then
+            echo "✓ WiFi monitor service installed"
+
+            # Check if service is running
+            if systemctl is-active --quiet ledmatrix-wifi-monitor.service 2>/dev/null; then
+                echo "✓ WiFi monitor service is running"
+            else
+                echo "⚠ WiFi monitor service installed but not running (may need required packages)"
+            fi
         else
-            echo "⚠ WiFi monitor service installed but not running (may need required packages)"
+            echo "⚠ WiFi monitor service file exists but not registered with systemd"
         fi
     else
-        echo "⚠ WiFi monitor service installation may have failed"
-    fi
+        echo "⚠ WiFi monitor service file not created (installation may have failed)"
+        echo "  You can install it later by running: sudo ./scripts/install/install_wifi_monitor.sh"
     fi
 else
     echo "⚠ install_wifi_monitor.sh not found; skipping WiFi monitor installation"

scripts/install/debug_install.sh

@@ -0,0 +1,85 @@
+#!/bin/bash
+# Quick diagnostic script to check why first_time_install.sh is failing
+# Run this on the Pi: bash debug_install.sh
+
+echo "=== Diagnostic Script for Installation Failure ==="
+echo ""
+
+echo "1. Checking if running as root:"
+if [ "$EUID" -eq 0 ]; then
+    echo "   ✓ Running as root (EUID=$EUID)"
+else
+    echo "   ✗ NOT running as root (EUID=$EUID, user=$(whoami))"
+fi
+echo ""
+
+echo "2. Checking if first_time_install.sh exists:"
+if [ -f "./first_time_install.sh" ]; then
+    echo "   ✓ Found ./first_time_install.sh"
+    echo "   Checking if executable:"
+    if [ -x "./first_time_install.sh" ]; then
+        echo "     ✓ Is executable"
+    else
+        echo "     ✗ NOT executable (fix with: chmod +x first_time_install.sh)"
+    fi
+else
+    echo "   ✗ NOT found in current directory"
+    echo "   Current directory: $(pwd)"
+fi
+echo ""
+
+echo "3. Testing argument passing with -y flag:"
+echo "   Running: bash ./first_time_install.sh -y --help 2>&1 | head -20"
+if [ -f "./first_time_install.sh" ]; then
+    bash ./first_time_install.sh -y --help 2>&1 | head -20 || echo "   ✗ Script failed or not found"
+else
+    echo "   ✗ first_time_install.sh not found"
+fi
+echo ""
+
+echo "4. Checking environment variable:"
+echo "   LEDMATRIX_ASSUME_YES=${LEDMATRIX_ASSUME_YES:-not set}"
+echo "   Testing with env: env LEDMATRIX_ASSUME_YES=1 bash -c 'echo ASSUME_YES would be set'"
+env LEDMATRIX_ASSUME_YES=1 bash -c 'echo "   ASSUME_YES would be: ${LEDMATRIX_ASSUME_YES:-not set}"'
+echo ""
+
+echo "5. Testing sudo with arguments:"
+echo "   Command: sudo -E env LEDMATRIX_ASSUME_YES=1 bash ./first_time_install.sh -y --help 2>&1 | head -20"
+if [ -f "./first_time_install.sh" ]; then
+    sudo -E env LEDMATRIX_ASSUME_YES=1 bash ./first_time_install.sh -y --help 2>&1 | head -20 || echo "   ✗ Sudo command failed"
+else
+    echo "   ✗ first_time_install.sh not found"
+fi
+echo ""
+
+echo "6. Checking /tmp permissions:"
+echo "   /tmp is writable: $([ -w /tmp ] && echo 'YES' || echo 'NO')"
+echo "   /tmp permissions: $(stat -c '%a' /tmp 2>/dev/null || echo 'unknown')"
+echo "   TMPDIR: ${TMPDIR:-not set}"
+echo ""
+
+echo "7. Checking stdin/TTY:"
+if [ -t 0 ]; then
+    echo "   ✓ stdin is a TTY (interactive)"
+else
+    echo "   ✗ stdin is NOT a TTY (non-interactive/pipe)"
+    echo "   This is expected when running via curl | bash"
+fi
+echo ""
+
+echo "8. Latest installation log:"
+# Determine project root directory (parent of scripts/install/)
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+PROJECT_ROOT_DIR="$(cd "$SCRIPT_DIR/../.." && pwd)"
+LOG_DIR="$PROJECT_ROOT_DIR/logs"
+LOG_FILE=$(ls -t "$LOG_DIR"/first_time_install_*.log 2>/dev/null | head -1)
+if [ -n "$LOG_FILE" ]; then
+    echo "   Found: $LOG_FILE"
+    echo "   Last 30 lines:"
+    tail -30 "$LOG_FILE" | sed 's/^/   /'
+else
+    echo "   No log files found in $LOG_DIR/"
+fi
+echo ""
+
+echo "=== Diagnostic Complete ==="

scripts/install/install_wifi_monitor.sh

@@ -40,20 +40,28 @@ if ! command -v nmcli >/dev/null 2>&1 && ! command -v iwlist >/dev/null 2>&1; th
 fi
 
 if [ ${#MISSING_PACKAGES[@]} -gt 0 ]; then
-    echo "⚠ The following packages are required for WiFi setup:"
+    echo "Installing required packages for WiFi setup:"
     for pkg in "${MISSING_PACKAGES[@]}"; do
         echo "  - $pkg"
     done
     echo ""
-    read -p "Install these packages now? (y/N): " -n 1 -r
-    echo ""
-    if [[ $REPLY =~ ^[Yy]$ ]]; then
-        sudo apt update
-        sudo apt install -y "${MISSING_PACKAGES[@]}"
-        echo "✓ Packages installed"
+
+    # Install packages automatically (no prompt)
+    # Use apt directly if running as root, otherwise use sudo
+    if [ "$EUID" -eq 0 ]; then
+        apt update || echo "⚠ apt update failed, continuing anyway..."
+        apt install -y "${MISSING_PACKAGES[@]}" || {
+            echo "⚠ Package installation failed, but continuing with WiFi monitor setup"
+            echo "  You may need to install packages manually: apt install -y ${MISSING_PACKAGES[*]}"
+        }
     else
-        echo "⚠ Skipping package installation. WiFi setup may not work correctly."
+        sudo apt update || echo "⚠ apt update failed, continuing anyway..."
+        sudo apt install -y "${MISSING_PACKAGES[@]}" || {
+            echo "⚠ Package installation failed, but continuing with WiFi monitor setup"
+            echo "  You may need to install packages manually: sudo apt install -y ${MISSING_PACKAGES[*]}"
+        }
     fi
+    echo "✓ Package installation completed"
 fi
 
 # Create service file with correct paths
@@ -81,7 +89,11 @@ WantedBy=multi-user.target
 EOF
 )
 
-echo "$SERVICE_FILE_CONTENT" | sudo tee /etc/systemd/system/ledmatrix-wifi-monitor.service > /dev/null
+if [ "$EUID" -eq 0 ]; then
+    echo "$SERVICE_FILE_CONTENT" | tee /etc/systemd/system/ledmatrix-wifi-monitor.service > /dev/null
+else
+    echo "$SERVICE_FILE_CONTENT" | sudo tee /etc/systemd/system/ledmatrix-wifi-monitor.service > /dev/null
+fi
 
 # Check WiFi connection status before enabling service
 echo ""
@@ -142,36 +154,52 @@ if [ "$WIFI_CONNECTED" = false ] && [ "$ETHERNET_CONNECTED" = false ]; then
     echo "  2. Or connect via Ethernet cable"
     echo "  3. Or proceed with installation - you can connect to LEDMatrix-Setup AP after reboot"
     echo ""
-    if [ -z "${ASSUME_YES:-}" ] && [ -z "${LEDMATRIX_ASSUME_YES:-}" ]; then
-        read -p "Continue with WiFi monitor installation? (y/N): " -n 1 -r
-        echo ""
-        if [[ ! $REPLY =~ ^[Yy]$ ]]; then
-            echo "Installation cancelled. Connect to WiFi/Ethernet and run this script again."
-            exit 0
-        fi
-    fi
+    echo "Proceeding with WiFi monitor installation..."
+    echo "  (WiFi monitor will enable AP mode if no network connection is detected)"
 fi
 
 # Reload systemd
 echo ""
 echo "Reloading systemd..."
-sudo systemctl daemon-reload
+if [ "$EUID" -eq 0 ]; then
+    systemctl daemon-reload
+else
+    sudo systemctl daemon-reload
+fi
 
 # Enable and start the service
 echo "Enabling WiFi monitor service to start on boot..."
-sudo systemctl enable ledmatrix-wifi-monitor.service
+if [ "$EUID" -eq 0 ]; then
+    systemctl enable ledmatrix-wifi-monitor.service
+else
+    sudo systemctl enable ledmatrix-wifi-monitor.service
+fi
 
 echo "Starting WiFi monitor service..."
-sudo systemctl start ledmatrix-wifi-monitor.service
+if [ "$EUID" -eq 0 ]; then
+    systemctl start ledmatrix-wifi-monitor.service || echo "⚠ Failed to start service (may start on reboot)"
+else
+    sudo systemctl start ledmatrix-wifi-monitor.service || echo "⚠ Failed to start service (may start on reboot)"
+fi
 
 # Check service status
 echo ""
 echo "Checking service status..."
-if sudo systemctl is-active --quiet ledmatrix-wifi-monitor.service; then
+if [ "$EUID" -eq 0 ]; then
+    SYSTEMCTL_CMD="systemctl"
+else
+    SYSTEMCTL_CMD="sudo systemctl"
+fi
+
+if $SYSTEMCTL_CMD is-active --quiet ledmatrix-wifi-monitor.service 2>/dev/null; then
     echo "✓ WiFi monitor service is running"
 else
     echo "⚠ WiFi monitor service failed to start. Check logs with:"
-    echo "  sudo journalctl -u ledmatrix-wifi-monitor -n 50"
+    if [ "$EUID" -eq 0 ]; then
+        echo "  journalctl -u ledmatrix-wifi-monitor -n 50"
+    else
+        echo "  sudo journalctl -u ledmatrix-wifi-monitor -n 50"
+    fi
 fi
 
 echo ""