Skip to content

fix: add reset() alias to ScrollHelper for plugin compatibility#290

Merged
ChuckBuilds merged 1 commit intomainfrom
fix/scroll-helper-reset-alias
Mar 21, 2026
Merged

fix: add reset() alias to ScrollHelper for plugin compatibility#290
ChuckBuilds merged 1 commit intomainfrom
fix/scroll-helper-reset-alias

Conversation

@ChuckBuilds
Copy link
Copy Markdown
Owner

@ChuckBuilds ChuckBuilds commented Mar 21, 2026

Summary

  • Multiple plugins (F1, UFC) independently called scroll_helper.reset() instead of scroll_helper.reset_scroll(), causing AttributeError and preventing scroll modes from displaying
  • Adds reset() as a convenience alias for reset_scroll() to prevent this class of bugs going forward

Test plan

  • Verify ScrollHelper instances respond to both .reset() and .reset_scroll()
  • Confirm F1 plugin scroll modes (qualifying, standings, calendar) display correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor
    • Enhanced internal API with an additional method alias for improved code flexibility.

Multiple plugins (F1, UFC) independently called scroll_helper.reset()
instead of scroll_helper.reset_scroll(), causing AttributeError and
preventing scroll modes from displaying. Adding reset() as an alias
prevents this class of bugs going forward.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f6e3523a-f587-4017-867a-6a036cfc0d26

📥 Commits

Reviewing files that changed from the base of the PR and between c8737d1 and 23e0959.

📒 Files selected for processing (1)
  • src/common/scroll_helper.py

📝 Walkthrough

Walkthrough

A new public reset() method has been added to the ScrollHelper class as an alias for the existing reset_scroll() method. This provides an additional callable entry point for resetting scroll state without altering the underlying implementation.

Changes

Cohort / File(s) Summary
ScrollHelper Public API
src/common/scroll_helper.py
Added a new reset() method as a public alias for the existing reset_scroll() method, expanding the public interface for scroll state management.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a reset() method alias to ScrollHelper to fix plugin compatibility issues.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/scroll-helper-reset-alias

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

@ChuckBuilds ChuckBuilds merged commit 442638d into main Mar 21, 2026
1 check passed
@ChuckBuilds ChuckBuilds deleted the fix/scroll-helper-reset-alias branch March 21, 2026 18:11
5ymb01 added a commit to 5ymb01/LEDMatrix that referenced this pull request Mar 23, 2026
Reconcile squash-merged PRs (ChuckBuilds#277, ChuckBuilds#290, ChuckBuilds#291) from upstream.
Resolve conflict in vegas_mode/coordinator.py: keep both the
interrupt check callback (upstream) and inline cycle restart (Dev).

Co-Authored-By: 5ymb01 <noreply@github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5ymb01 added a commit to 5ymb01/LEDMatrix that referenced this pull request Mar 23, 2026
Reconcile squash-merged PRs (ChuckBuilds#277, ChuckBuilds#290, ChuckBuilds#291) from upstream.
Resolve conflict in vegas_mode/coordinator.py: keep both the
interrupt check callback (upstream) and inline cycle restart (wip).

Co-Authored-By: 5ymb01 <noreply@github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant