fix: add reset() alias to ScrollHelper for plugin compatibility#290
fix: add reset() alias to ScrollHelper for plugin compatibility#290ChuckBuilds merged 1 commit intomainfrom
Conversation
Multiple plugins (F1, UFC) independently called scroll_helper.reset() instead of scroll_helper.reset_scroll(), causing AttributeError and preventing scroll modes from displaying. Adding reset() as an alias prevents this class of bugs going forward. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new public Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
Reconcile squash-merged PRs (ChuckBuilds#277, ChuckBuilds#290, ChuckBuilds#291) from upstream. Resolve conflict in vegas_mode/coordinator.py: keep both the interrupt check callback (upstream) and inline cycle restart (Dev). Co-Authored-By: 5ymb01 <noreply@github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reconcile squash-merged PRs (ChuckBuilds#277, ChuckBuilds#290, ChuckBuilds#291) from upstream. Resolve conflict in vegas_mode/coordinator.py: keep both the interrupt check callback (upstream) and inline cycle restart (wip). Co-Authored-By: 5ymb01 <noreply@github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
scroll_helper.reset()instead ofscroll_helper.reset_scroll(), causingAttributeErrorand preventing scroll modes from displayingreset()as a convenience alias forreset_scroll()to prevent this class of bugs going forwardTest plan
ScrollHelperinstances respond to both.reset()and.reset_scroll()🤖 Generated with Claude Code
Summary by CodeRabbit