Leaderboard hangs at end due to overestimate of time#53
Merged
ChuckBuilds merged 3 commits intoChuckBuilds:mainfrom Sep 22, 2025
Merged
Leaderboard hangs at end due to overestimate of time#53ChuckBuilds merged 3 commits intoChuckBuilds:mainfrom
ChuckBuilds merged 3 commits intoChuckBuilds:mainfrom
Conversation
|
im having the same issue, how did you fix it? |
Collaborator
Author
|
see the changes in the PR. |
Collaborator
Author
|
@ChuckBuilds ready for ur review if u get a chance |
Owner
|
Merging but I need to keep iterating on this. |
Collaborator
Author
|
You could honestly just make the time super long and then rely on the exception to end it?? then u don't really have to worry about how long it is or trying to calculate a time 🤷♂️ |
|
Let me know if you get this same issue so it may not be leaderboard
specific. Try turning leaderboard off and text on. Now I get the hang on
the text
http://www.torontonightclub.com
…On Mon, Sep 22, 2025, 10:36 a.m. Alex Resnick ***@***.***> wrote:
*legoguy1000* left a comment (ChuckBuilds/LEDMatrix#53)
<#53 (comment)>
You could honestly just make the time super long and then rely on the
exception to end it?? then u don't really have to worry about how long it
is or trying to calculate a time 🤷♂️
—
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXO7PD2H2Y52V4LZUTAMML33UACPVAVCNFSM6AAAAACG5VNCQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJZGQ2DQNJYGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Owner
... That's a good idea. This dynamic duration has gotten way too complicated. I'll try this - thanks! |
ChuckBuilds
added a commit
that referenced
this pull request
Sep 22, 2025
- Add maximum display time cap (120s) to prevent hanging - Implement dynamic scroll speed tracking with runtime measurements - Simplify complex timing logic that was causing hangs - Add enhanced progress tracking and logging - Add configurable safety buffer (10s) - Update config template with new timing options - Add comprehensive test suite for timing logic Fixes the 30-second hanging issue reported in PR #53 by providing multiple layers of protection against time overestimation.
ChuckBuilds
added a commit
that referenced
this pull request
Sep 22, 2025
…ending - Remove complex dynamic duration calculations - Remove safety buffer complexity - Remove scroll speed tracking and measurements - Use simple 10-minute timeout (600s) for both display_duration and max_display_time - Let content determine when display is complete via existing StopIteration logic - Update display controller to use simplified duration approach - Clean up config template to remove unused timing settings This approach is much more reliable than trying to predict content duration and eliminates the hanging issues reported in PR #53.
ChuckBuilds
added a commit
that referenced
this pull request
Sep 23, 2025
* Fix leaderboard timing issues with comprehensive improvements - Add maximum display time cap (120s) to prevent hanging - Implement dynamic scroll speed tracking with runtime measurements - Simplify complex timing logic that was causing hangs - Add enhanced progress tracking and logging - Add configurable safety buffer (10s) - Update config template with new timing options - Add comprehensive test suite for timing logic Fixes the 30-second hanging issue reported in PR #53 by providing multiple layers of protection against time overestimation. * Simplify leaderboard timing to use long timeout with exception-based ending - Remove complex dynamic duration calculations - Remove safety buffer complexity - Remove scroll speed tracking and measurements - Use simple 10-minute timeout (600s) for both display_duration and max_display_time - Let content determine when display is complete via existing StopIteration logic - Update display controller to use simplified duration approach - Clean up config template to remove unused timing settings This approach is much more reliable than trying to predict content duration and eliminates the hanging issues reported in PR #53. * Fix configuration structure to use centralized display_durations - Remove redundant display_duration from leaderboard section - Use main display_durations.leaderboard (300s) for fixed duration mode - Update leaderboard manager to read from centralized config - Increase leaderboard default duration from 60s to 300s for better content coverage - Maintain dynamic_duration option for user choice between fixed/dynamic modes - Add comprehensive scroll behavior analysis and testing This completes the leaderboard timing improvements with proper config structure. * scroll every frame to be smoother like the stock ticker instead of waiting per subsecond * leaderboard block api calls while scrolling * leaderboard debugging * added leaderboard fps logging * leaderboard frame control and optimizations * background update memory leak for scrolling text found and first solution applied * tuning scroll speeds * working display scrolls * revert scroll delay to 0.01 (about 100fps) * revert min duration of leaderboard * remove onetime test scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For me the leaderboard is overestimating the amount of time to run through the display and then just hangs at the end for almost 30 seconds. I added an exception that forces it to move to the next view.