Skip to content

fix(masters-tournament): wrap-text flush and manifest date sync#100

Open
ChuckBuilds wants to merge 2 commits intomainfrom
fix/masters-wrap-text-and-manifest
Open

fix(masters-tournament): wrap-text flush and manifest date sync#100
ChuckBuilds wants to merge 2 commits intomainfrom
fix/masters-wrap-text-and-manifest

Conversation

@ChuckBuilds
Copy link
Copy Markdown
Owner

@ChuckBuilds ChuckBuilds commented Apr 10, 2026

Summary

  • Flush current_line before character-breaking an oversized word in _wrap_text, preventing previous text from being glued to broken characters
  • Update last_updated in manifest.json to 2026-04-10 to match the 2.3.0 release date

Test plan

  • Verify long words in fun facts render on separate lines from preceding text
  • Confirm update_registry.py syncs correctly with the updated last_updated date

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text wrapping to correctly handle oversized words across multiple lines, preventing them from being concatenated to previously rendered content
  • Chores

    • Updated plugin metadata

…sized words, sync manifest date

- In _wrap_text, flush any accumulated current_line before starting
  character-level breaking of an oversized word, preventing previous
  text from being glued to the broken characters
- Update last_updated in manifest.json to 2026-04-10 to match the
  2.3.0 release date

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Warning

Rate limit exceeded

@ChuckBuilds has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 11 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 11 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6d630845-cd64-4c73-8b00-2a800708f720

📥 Commits

Reviewing files that changed from the base of the PR and between 9ad0c67 and 17333f0.

📒 Files selected for processing (1)
  • plugins/masters-tournament/manager.py
📝 Walkthrough

Walkthrough

Updated the manifest timestamp and fixed text-wrapping logic in the masters tournament renderer. The _wrap_text() function now correctly handles oversized words by committing the current line before breaking words into character chunks.

Changes

Cohort / File(s) Summary
Manifest Update
plugins/masters-tournament/manifest.json
Updated last_updated field from 2026-04-09 to 2026-04-10.
Text Wrapping Logic Fix
plugins/masters-tournament/masters_renderer.py
Fixed _wrap_text() to properly commit the current line to lines and clear it before breaking oversized words into character chunks, preventing unintended concatenation with previously built text.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures both main changes: fixing text wrapping logic and synchronizing the manifest date.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/masters-wrap-text-and-manifest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@plugins/masters-tournament/manifest.json`:
- Line 107: Update the plugin manifest to reflect the code change in
masters_renderer.py by bumping the patch version (e.g., 2.3.0 → 2.3.1), set the
top-level "version" field to that new version, prepend a new entry for the new
version at the start of the "versions" array (including updated "last_updated"
and any relevant notes), and ensure "last_updated" remains correct; this keeps
the manifest (version, versions[], last_updated) in sync with the code change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 105c7697-2b39-4d5c-bffc-c0d66f02d136

📥 Commits

Reviewing files that changed from the base of the PR and between 2b1361e and 9ad0c67.

📒 Files selected for processing (2)
  • plugins/masters-tournament/manifest.json
  • plugins/masters-tournament/masters_renderer.py

}
],
"last_updated": "2026-04-09",
"last_updated": "2026-04-10",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Manifest version bump is missing for this code change.

last_updated was synced, but the plugin code changed in plugins/masters-tournament/masters_renderer.py, so the manifest should also bump patch version (e.g., 2.3.02.3.1) and prepend the new entry in versions.

Suggested manifest update
-  "version": "2.3.0",
+  "version": "2.3.1",
   "versions": [
+    {
+      "version": "2.3.1",
+      "released": "2026-04-10",
+      "ledmatrix_min_version": "2.0.0"
+    },
     {
       "version": "2.3.0",
       "released": "2026-04-10",
       "ledmatrix_min_version": "2.0.0"
     },

As per coding guidelines: “Plugin version MUST be bumped in plugins/<plugin-id>/manifest.json whenever any plugin code changes” and “Add the new version FIRST … and keep the version field in sync with the top entry in versions.”

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@plugins/masters-tournament/manifest.json` at line 107, Update the plugin
manifest to reflect the code change in masters_renderer.py by bumping the patch
version (e.g., 2.3.0 → 2.3.1), set the top-level "version" field to that new
version, prepend a new entry for the new version at the start of the "versions"
array (including updated "last_updated" and any relevant notes), and ensure
"last_updated" remains correct; this keeps the manifest (version, versions[],
last_updated) in sync with the code change.

Track player scores between leaderboard updates and detect score
improvements. When a player makes birdie or better, queue a live alert
that renders with the appropriate styling (gold header for eagles,
green for birdies) via the existing render_live_alert renderer.

Alerts rotate on a configurable dwell timer (live_action.duration),
then fall back to showing the current leader.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant