fix(basketball): fix records display and reduce no-live-games log noise

[ChuckBuilds]

• When both show_ranking and show_records are enabled, fall back to showing the team record if no ranking is available (previously showed nothing for unranked teams)
• Lower "no game data available" log from WARNING to DEBUG since the display controller already skips modes with no content
• Fix GameRenderer config reading to find show_records/show_ranking from per-league display_options instead of a nonexistent defaults key
• Fix GameRenderer to use flat game dict format (home_abbr, home_score, home_record) matching what sports.py produces instead of nested home_team/away_team dicts
• Fix scroll_display game type detection to use is_live/is_final/ is_upcoming flags instead of nested status.state

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Improved team ranking and record display fallback behavior on the scoreboard.
  • Enhanced game status rendering for live, recent, and upcoming games.
  • Reduced unnecessary warning messages in system logs.

• Improvements

  • More robust handling of league display options and settings.
  • Better accuracy in game time and status information display.

[coderabbitai]

📝 Walkthrough

Walkthrough

The basketball scoreboard plugin is refactored to use flat game dictionary fields instead of nested home_team/away_team structures. Additionally, when both rankings and records display options are enabled, the system now falls back to displaying team records when ranking data is unavailable, applied consistently across rendering logic.

Changes

Cohort / File(s)	Summary
Data Structure Refactoring plugins/basketball-scoreboard/game_renderer.py, plugins/basketball-scoreboard/scroll_display.py	Migrated from nested team structures to flat game dict fields (home_abbr, away_abbr, home_logo_path, away_logo_path, game_date, game_time, period_text, clock, is_halftime, status_text). Updated game type determination to use flat flags (is_live, is_final, is_upcoming) instead of state-based logic.
Fallback Logic & Display Adjustments plugins/basketball-scoreboard/basketball.py, plugins/basketball-scoreboard/sports.py	Added record fallback rendering when team rankings are unavailable; displays away_record or home_record instead of empty strings. Adjusted logging level from warning to debug when no current game exists. Applied consistently across score view, format_score, and upcoming/recent sections.

Estimated Code Review Effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 The scoreboard danced with flatter grace,
No nested depths to slow the pace!
When rankings hide, records appear,
A fallback whisper, crisp and clear.
The game flows smooth through every file,
Hop along, it's worth your while! 🏀

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately summarizes the main changes: fixing records display fallback for unranked teams and reducing log noise from the no-live-games warning.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/basketball-records-and-live-warning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

plugins/basketball-scoreboard/sports.py (2)

1-31: ⚠️ Potential issue | 🟡 Minor

Bump version from 1.0.5 to 1.0.6 in plugins/basketball-scoreboard/manifest.json.

Code changes to plugin files require a version bump per semantic versioning guidelines. Update the version field and add a new entry to the versions array with the bumped version and today's release date. For bug fixes, use PATCH version bump (1.0.5 → 1.0.6).

---

2217-2228: ⚠️ Potential issue | 🔴 Critical

Fix critical indentation bug: live game data fetch is incorrectly nested inside if self.show_ranking:

Lines 2222–2412 (all live game fetching and processing) are indented under if self.show_ranking: (line 2218). When show_ranking is False, _fetch_data() is never called, so live games will never appear. De-indent the entire data = self._fetch_data() block through line 2412 by one level to align with the if self.show_ranking: block.

Proposed fix

            if self.show_ranking:
                self._fetch_team_rankings()

            # Fetch live game data
-                data = self._fetch_data()
-                new_live_games = []
+            data = self._fetch_data()
+            new_live_games = []

The entire block from data = self._fetch_data() (line 2222) through the end of live-game processing (around line 2412) needs to be de-indented by one level.

🤖 Fix all issues with AI agents

In `@plugins/basketball-scoreboard/game_renderer.py`:
- Around line 329-330: The current conversion uses str(game.get("home_score",
"0")) which still yields "None" when the key exists but its value is None;
update the handling in game_renderer.py so you first retrieve the raw value
(e.g., val = game.get("home_score")) and then set home_score = str(val) if val
is not None else "0" (and do the same for away_score) to ensure explicit None
values render as "0" instead of "None".

🧹 Nitpick comments (1)

plugins/basketball-scoreboard/sports.py (1)

1486-1526: Consider extracting the duplicated ranking/record fallback logic into a shared helper.

The same ~20 lines of if self.show_ranking and self.show_records: ... elif ... elif ... else ... logic is repeated verbatim in:

• SportsUpcoming._draw_scorebug_layout (away + home)
• SportsRecent._draw_scorebug_layout (away + home)
• BasketballLive._draw_scorebug_layout in basketball.py (away + home)

GameRenderer._get_team_display_text already encapsulates this — a similar helper on SportsCore could eliminate the duplication.

Also applies to: 2005-2045

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Minor: str(None) produces "None" if score value is explicitly None.

game.get("home_score", "0") returns None (not "0") when the key exists with a None value, so str(None) → "None" would render on screen. In practice sports.py always normalizes scores to strings, but a small guard would improve robustness:

Proposed fix

-        home_score = str(game.get("home_score", "0"))
-        away_score = str(game.get("away_score", "0"))
+        home_score = str(game.get("home_score") or "0")
+        away_score = str(game.get("away_score") or "0")

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	home_score = str(game.get("home_score", "0"))
	away_score = str(game.get("away_score", "0"))
	home_score = str(game.get("home_score") or "0")
	away_score = str(game.get("away_score") or "0")

🤖 Prompt for AI Agents

In `@plugins/basketball-scoreboard/game_renderer.py` around lines 329 - 330, The
current conversion uses str(game.get("home_score", "0")) which still yields
"None" when the key exists but its value is None; update the handling in
game_renderer.py so you first retrieve the raw value (e.g., val =
game.get("home_score")) and then set home_score = str(val) if val is not None
else "0" (and do the same for away_score) to ensure explicit None values render
as "0" instead of "None".