Skip to content

fix(baseball): center score between logos, remove abbreviations#60

Merged
ChuckBuilds merged 2 commits intomainfrom
fix/baseball-score-layout
Mar 30, 2026
Merged

fix(baseball): center score between logos, remove abbreviations#60
ChuckBuilds merged 2 commits intomainfrom
fix/baseball-score-layout

Conversation

@ChuckBuilds
Copy link
Copy Markdown
Owner

@ChuckBuilds ChuckBuilds commented Mar 30, 2026

Summary

  • Center the live game score between logos as "away-home" (e.g. "3-5") matching the football scoreboard pattern
  • Remove team abbreviations from the score display — logos already identify teams
  • Score is dynamically positioned below the bases/count cluster to prevent overlap on smaller displays
  • Bump version 1.5.4 → 1.5.5

Test plan

  • Verify live game score renders centered at bottom as "3-5" format
  • Verify no team abbreviation text appears on or near logos
  • Verify bases diamond, outs, and count are not covered by score
  • Check recent/upcoming game rendering is unchanged

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Improved score placement to avoid overlap with other on-screen game elements.
  • Style

    • Switched to a centered single-score display for a cleaner, more readable scoreboard.
  • Chores

    • Plugin metadata updated to version 1.5.5 and refreshed release/date info.

Match the football scoreboard pattern: display score as centered
"away-home" (e.g. "3-5") instead of corner-positioned "ABBR:score".
Score is positioned below the bases/count cluster to avoid overlap.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5b987363-7d24-4e84-9abb-5ac2168fbe01

📥 Commits

Reviewing files that changed from the base of the PR and between 7d71ea2 and 74f3b19.

📒 Files selected for processing (2)
  • plugins.json
  • plugins/baseball-scoreboard/game_renderer.py
✅ Files skipped from review due to trivial changes (1)
  • plugins.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • plugins/baseball-scoreboard/game_renderer.py

📝 Walkthrough

Walkthrough

Score rendering in live-game view now shows a single centered string away_score-home_score and its vertical position is clamped to avoid overlapping the bases/count cluster. Plugin manifest and index metadata bumped from 1.5.4 → 1.5.5.

Changes

Cohort / File(s) Summary
Score Rendering Logic
plugins/baseball-scoreboard/game_renderer.py
Replaced two corner score texts (away_abbr:away_score, home_abbr:home_score) with a single centered away_score-home_score. Compute horizontal center via draw.textlength; vertical Y is clamped relative to the bases/count cluster bottom to avoid overlap. Removed corner-specific width measurement and draws.
Plugin Manifest
plugins/baseball-scoreboard/manifest.json
Bumped plugin version 1.5.4 → 1.5.5 and added a versions[] entry for 1.5.5 (released: 2026-03-29, ledmatrix_min: 2.0.0).
Plugins Index
plugins.json
Updated baseball-scoreboard metadata: last_updated advanced to 2026-03-29 and latest_version bumped to 1.5.5.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: centering the score display and removing team abbreviations from the baseball scoreboard rendering.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/baseball-score-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@plugins/baseball-scoreboard/game_renderer.py`:
- Around line 285-289: The current assignment of score_y uses max(cluster_bottom
+ 1, self.display_height - font_height - 2) which can push text below the
drawable area on small displays; change the logic to clamp score_y to not exceed
the bottom drawable limit (compute bottom_limit = self.display_height -
font_height - 2 and set score_y = min(cluster_bottom + 1, bottom_limit)), and
optionally ensure score_y is >= 0, then pass that clamped value into
_draw_text_with_outline; update the score_y calculation where it appears
(referencing score_y, cluster_bottom, has_count_data, display_height,
font_height, and _draw_text_with_outline).

In `@plugins/baseball-scoreboard/manifest.json`:
- Line 4: Update the registry metadata in plugins.json so it matches the
manifest: locate the baseball-scoreboard plugin entry and change the
"latest_version" field from "1.5.4" to "1.5.5" (and ensure any related version
list or metadata references for the baseball-scoreboard entry reflect 1.5.5);
verify the manifest "version" and the plugins.json "latest_version" now match to
avoid stale distribution metadata.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d389c4b3-2aa7-4bd5-9d0a-8cacea9984e3

📥 Commits

Reviewing files that changed from the base of the PR and between 2e87c29 and 7d71ea2.

📒 Files selected for processing (2)
  • plugins/baseball-scoreboard/game_renderer.py
  • plugins/baseball-scoreboard/manifest.json

Use min() instead of max() so score_y stays within display bounds on
small displays. Update plugins.json latest_version to match manifest.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ChuckBuilds ChuckBuilds merged commit 8a98620 into main Mar 30, 2026
1 check passed
@ChuckBuilds ChuckBuilds deleted the fix/baseball-score-layout branch March 30, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant