fix(baseball): center score between logos, remove abbreviations#60
fix(baseball): center score between logos, remove abbreviations#60ChuckBuilds merged 2 commits intomainfrom
Conversation
Match the football scoreboard pattern: display score as centered "away-home" (e.g. "3-5") instead of corner-positioned "ABBR:score". Score is positioned below the bases/count cluster to avoid overlap. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughScore rendering in live-game view now shows a single centered string Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/baseball-scoreboard/game_renderer.py`:
- Around line 285-289: The current assignment of score_y uses max(cluster_bottom
+ 1, self.display_height - font_height - 2) which can push text below the
drawable area on small displays; change the logic to clamp score_y to not exceed
the bottom drawable limit (compute bottom_limit = self.display_height -
font_height - 2 and set score_y = min(cluster_bottom + 1, bottom_limit)), and
optionally ensure score_y is >= 0, then pass that clamped value into
_draw_text_with_outline; update the score_y calculation where it appears
(referencing score_y, cluster_bottom, has_count_data, display_height,
font_height, and _draw_text_with_outline).
In `@plugins/baseball-scoreboard/manifest.json`:
- Line 4: Update the registry metadata in plugins.json so it matches the
manifest: locate the baseball-scoreboard plugin entry and change the
"latest_version" field from "1.5.4" to "1.5.5" (and ensure any related version
list or metadata references for the baseball-scoreboard entry reflect 1.5.5);
verify the manifest "version" and the plugins.json "latest_version" now match to
avoid stale distribution metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d389c4b3-2aa7-4bd5-9d0a-8cacea9984e3
📒 Files selected for processing (2)
plugins/baseball-scoreboard/game_renderer.pyplugins/baseball-scoreboard/manifest.json
Use min() instead of max() so score_y stays within display bounds on small displays. Update plugins.json latest_version to match manifest. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
"away-home"(e.g."3-5") matching the football scoreboard patternTest plan
"3-5"format🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Style
Chores