Skip to content

fix(baseball,odds): handle missing abbreviation in ESPN NCAA data#61

Closed
ChuckBuilds wants to merge 1 commit intomainfrom
fix/abbreviation-keyerror
Closed

fix(baseball,odds): handle missing abbreviation in ESPN NCAA data#61
ChuckBuilds wants to merge 1 commit intomainfrom
fix/abbreviation-keyerror

Conversation

@ChuckBuilds
Copy link
Copy Markdown
Owner

Summary

  • Some NCAA baseball teams in ESPN API responses lack the abbreviation field, causing KeyError crashes in baseball.py:141 and odds-ticker/manager.py:1152
  • Use .get() with fallback to team['name'][:3], matching the pattern already used in sports.py and data_manager.py
  • Affects: baseball-scoreboard (1.5.4 → 1.5.5), odds-ticker (1.1.1 → 1.1.2)

Test plan

  • Verify NCAA baseball recent/upcoming games no longer throw KeyError: 'abbreviation'
  • Verify odds ticker handles NCAA baseball games without abbreviation
  • Check journalctl for zero KeyError: 'abbreviation' after deploy

🤖 Generated with Claude Code

Some NCAA baseball teams lack the 'abbreviation' field in ESPN API
responses, causing KeyError crashes. Use .get() with fallback to
team name truncated to 3 chars, matching the pattern already used
in sports.py and data_manager.py.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Warning

Rate limit exceeded

@ChuckBuilds has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 47 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 47 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9a90bfb3-f74f-4c01-b96a-e4e9f959c6dd

📥 Commits

Reviewing files that changed from the base of the PR and between 8a98620 and 3b8bfd4.

📒 Files selected for processing (4)
  • plugins/baseball-scoreboard/baseball.py
  • plugins/baseball-scoreboard/manifest.json
  • plugins/odds-ticker/manager.py
  • plugins/odds-ticker/manifest.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/abbreviation-keyerror

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChuckBuilds
Copy link
Copy Markdown
Owner Author

Superseded by #63 which includes this fix plus custom font support and other baseball/odds fixes.

@ChuckBuilds ChuckBuilds deleted the fix/abbreviation-keyerror branch March 30, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant