엑셀 파싱기 : feat : 엑셀 파싱기 기능 구현 https://github.com/Chuseok22/excel-parse…#2
Hidden character warning
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new Excel parsing application with a Tkinter GUI, service layer, entrypoint, documentation, and CI workflow.
- Added a Tkinter-based UI for selecting Excel files, choosing output folders, and displaying logs.
- Created
ExcelParseServiceto read an Excel file, split data by a selected column’s unique values, and write separate files. - Set up the application entrypoint (
main.py), initial README, and a GitHub Actions workflow to build a Windows executable.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/ui_main.py | Added main UI class with file browsing, progress bar, and logging. |
| src/services/excel_parse_service.py | Implemented Excel read/write and per-value splitting logic. |
| main.py | Defined application entrypoint initializing the Tkinter UI. |
| README.md | Added project overview, installation, usage instructions. |
| .github/workflows/build.yml | Added CI workflow for building and releasing Windows executable. |
Comments suppressed due to low confidence (2)
src/services/excel_parse_service.py:74
- The function
os.path.splittextdoes not exist; it should beos.path.splitextto correctly separate the base name and extension.
file_base, file_ext = os.path.splittext(file_name)
src/ui/ui_main.py:68
- [nitpick] Attaching the scrollbar directly to the
Textwidget can complicate layout; consider creating it inlog_framealongside the text widget for clearer structure.
scrollbar = ttk.Scrollbar(self.log_text, command=self.log_text.yview)
| ### 기본 실행 | ||
|
|
||
| ```bash | ||
| python app.py |
There was a problem hiding this comment.
The README refers to python app.py, but the entrypoint script is main.py. Please update the usage instructions to python main.py or rename the script accordingly.
| python app.py | |
| python main.py |
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| - name: Build Overtime Analyzer EXE |
There was a problem hiding this comment.
[nitpick] The workflow step is named 'Build Overtime Analyzer EXE', which doesn’t match the Excel Parser project. Consider renaming it to 'Build Excel Parser EXE' for clarity.
| - name: Build Overtime Analyzer EXE | |
| - name: Build Excel Parser EXE |
There was a problem hiding this comment.
Pull Request Overview
This PR implements an Excel parsing application featuring a GUI interface for file selection, Excel file processing using pandas, and an automated build process for generating an executable. Key changes include the UI implementation with file browsing and logging, Excel parsing logic that groups data by a specified column, and updates to build scripts and CI workflows for packaging the application.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/ui_main.py | Introduces the tkinter-based UI and threading for Excel processing |
| src/services/excel_parse_service.py | Implements Excel file reading, parsing, and writing functionality |
| main.py | Provides the application entry point |
| build.py | Adds a build script using PyInstaller for creating an executable |
| README.md | Updates documentation and usage instructions |
| .github/workflows/build.yml | Configures CI workflow for building and releasing the executable |
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:30
- [nitpick] The comment refers to 'Overtime Analyzer EXE' which is inconsistent with this project's context (Excel Parser). Consider updating the comment to 'Upload Excel Parser EXE as artifact' for clarity.
- name: Upload Overtime Analyzer EXE as artifact
src/services/excel_parse_service.py:74
- The function 'os.path.splittext' appears to be a typo. It should be replaced with the correct function 'os.path.splitext' to properly separate the file name and extension.
file_base, file_ext = os.path.splittext(file_name)
…r/issues/1