posters list whithout filter#4
Draft
Cimanel wants to merge 2 commits into
Draft
Conversation
Owner
Cimanel
commented
Apr 21, 2022
Cimanel
commented
- posters list
- filter panel
djhi
approved these changes
Apr 21, 2022
slax57
reviewed
Apr 21, 2022
| </Box> | ||
| ); | ||
|
|
||
| const TitlebarImageList = () => { |
There was a problem hiding this comment.
That's a strange name for a component with no titlebar 🤔
Comment on lines
+54
to
+55
| src={`${item.image}`} | ||
| srcSet={`${item.image}`} |
There was a problem hiding this comment.
Suggested change
| src={`${item.image}`} | |
| srcSet={`${item.image}`} | |
| src={item.image} | |
| srcSet={item.image} |
Also, why do you need srcSet ?
| /> | ||
| <ImageListItemBar | ||
| title={item.reference} | ||
| subtitle={`${item.width}x${item.height}, ${item.price} $US`} |
There was a problem hiding this comment.
It would be nice not to have $US as a constant. Ideally a component (MUI or RA) making use of { style: "currency", currency: "USD" } for the formatting.
| rowHeight={180} | ||
| > | ||
| {data.map((item) => ( | ||
| <ImageListItem key={item.image}> |
There was a problem hiding this comment.
Using item.image as a key is a bit weird. Why not use item.id?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.