Skip to content

fix: install hadolint for hadolint command#175

Merged
brivu merged 7 commits into
masterfrom
fix/install-hadolint
Feb 21, 2023
Merged

fix: install hadolint for hadolint command#175
brivu merged 7 commits into
masterfrom
fix/install-hadolint

Conversation

@brivu
Copy link
Copy Markdown
Contributor

@brivu brivu commented Feb 16, 2023

Currently if the docker/hadolint command is used with an executor other than the hadolint docker image, the command fails. This PR installs hadolint if it isn't already.

@brivu brivu requested a review from a team as a code owner February 16, 2023 23:11
@brivu brivu self-assigned this Feb 16, 2023
@brivu brivu linked an issue Feb 16, 2023 that may be closed by this pull request
Hadolint command expects Hadolint to be installed locally, doesn't use Docker image #170
Closed
EricRibeiro
EricRibeiro suggested changes Feb 16, 2023
View reviewed changes
Comment thread src/scripts/hadolint.sh Outdated
@brivu brivu mentioned this pull request Feb 17, 2023
Closed
@orb-publisher
Copy link
Copy Markdown

orb-publisher commented Feb 17, 2023

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:a06236d8e3340e54b8c3c4fb9e95776084a35733

@brivu brivu requested a review from EricRibeiro February 17, 2023 23:26
EricRibeiro
EricRibeiro reviewed Feb 17, 2023
View reviewed changes
Comment thread src/scripts/hadolint.sh Outdated
@orb-publisher
Copy link
Copy Markdown

orb-publisher commented Feb 18, 2023

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:c738e3152f32245b721d8aad4fa33f3c08b54386

@brivu brivu requested a review from KyleTryon February 21, 2023 16:14
@orb-publisher
Copy link
Copy Markdown

orb-publisher commented Feb 21, 2023

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:c738e3152f32245b721d8aad4fa33f3c08b54386

@orb-publisher
Copy link
Copy Markdown

orb-publisher commented Feb 21, 2023

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:fd6f8a79381e3f7e7603519341eefe854f8a5c2d

@brivu brivu merged commit b6600db into master Feb 21, 2023
@brivu brivu deleted the fix/install-hadolint branch February 21, 2023 20:49
@orb-publisher
Copy link
Copy Markdown

orb-publisher commented Feb 21, 2023

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:b6600db35dd7b9b376f91b3e0fd27dcabc538125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@EricRibeiro EricRibeiro EricRibeiro approved these changes

@KyleTryon KyleTryon KyleTryon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brivu brivu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hadolint command expects Hadolint to be installed locally, doesn't use Docker image

4 participants

@brivu @orb-publisher @EricRibeiro @KyleTryon