Use new information schema syntax for HistoryRepository checks#70
Merged
lauxjpn merged 2 commits intoCirrusRedOrg:masterfrom Nov 26, 2020
Merged
Use new information schema syntax for HistoryRepository checks#70lauxjpn merged 2 commits intoCirrusRedOrg:masterfrom
lauxjpn merged 2 commits intoCirrusRedOrg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JetHistoryRepository was still using the old
SHOW TABLESsyntax.While we are at it, we also now throw if any of the block methods (used for idempotent scripts) is being called, because Jet does not have procedural
IFstatements etc., so the previous code would just fail.However, since we are already parsing the commands anyway, and also support the simple
IF (NOT) EXISTS (foo) THENsyntax, we could actually supportIF...BEGIN...ENDblocks in the future, if there is need in the community for it.But since this is all provider customized syntax, a generated idempotent script would need to be executed using
System.Data.Jetto work, so we should provide a simple script execution class and a wrapper command line tool for that.Fixes #69