Prevent runaway command line execs#7
Open
FabianPonce wants to merge 2 commits intoCiscoDevNet:masterfrom
Open
Conversation
…ity of an unbounded number of processes being spawned due to a failure.
FabianPonce
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently installed these scripts on an virtualized CSR 1000V and that was correlated with some new failures that the devices started to experience. We haven't nailed down the precise root cause, but we do believe that the error handling here could've made the problem worse by not eventually failing.
This pull request changes the calls to
cli.executesuch that a failure to return a CLI response for any reason will no longer retry in an infinite loop. I wasn't sure whether or not the retry logic had been added to address some transient failures that were normal in IOS world, so I just capped the limit for retries at 3.