Skip to content

Conversation

@anoto-moniz
Copy link
Collaborator

Citrine Python PR

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@anoto-moniz anoto-moniz changed the base branch from main to feature/pla-13149-bump-dependencies January 5, 2024 21:06
@anoto-moniz anoto-moniz marked this pull request as ready for review January 5, 2024 21:07
@anoto-moniz anoto-moniz requested a review from kroenlein January 5, 2024 21:07
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up.

@anoto-moniz anoto-moniz force-pushed the feature/pla-13752-correct-warnings-in-docs-build branch from 679a71a to df14af8 Compare January 9, 2024 18:15
@anoto-moniz anoto-moniz force-pushed the feature/pla-13149-bump-dependencies branch 2 times, most recently from 6488b93 to 6b94156 Compare January 9, 2024 19:26
Base automatically changed from feature/pla-13149-bump-dependencies to release/v3.0 January 9, 2024 19:26
Since we're generating our API docs, one of our tables of contents must
link to it, or else it will throw a warning. So I've added it to the
main page. That main page TOC goes multiple levels deep, so it will show
the generated page's name. Since we were starting it at src/, that was
its name, which wouldn't make much sense to users. So I tweaked it to
start at src/citrine/.
@anoto-moniz anoto-moniz force-pushed the feature/pla-13752-correct-warnings-in-docs-build branch from df14af8 to 7202b4a Compare January 9, 2024 19:28
@anoto-moniz anoto-moniz merged commit 8e0420f into release/v3.0 Jan 9, 2024
@anoto-moniz anoto-moniz deleted the feature/pla-13752-correct-warnings-in-docs-build branch January 9, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants